development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 13:29:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

extract _addLeakageTraceLogic-util

Browse source
This commit is contained in:
Johannes Rieken 2022-02-11 15:10:20 +01:00
parent 447887fae9
commit 665a9c61a8
No known key found for this signature in database
GPG key ID: 96634B5AF12F8798
1 changed files with 27 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
src/vs/base/common/event.ts
View file

@ -10,8 +10,23 @@ import { combinedDisposable, Disposable, DisposableStore, IDisposable, toDisposa
import { LinkedList } from 'vs/base/common/linkedList';
import { StopWatch } from 'vs/base/common/stopwatch';
let TRACE_LIKEY_SNAPSHOT_LEAKAGE = false;
// TRACE_LIKEY_SNAPSHOT_LEAKAGE = Boolean("true"); // causes an ESLint warning so that this isn't pushed by accident
function _addLeakageTraceLogic(options: EmitterOptions) {
let enabled = false;
// enabled = Boolean("true"); // causes an ESLint warning so that this isn't pushed by accident
if (enabled) {
const { onListenerDidAdd: origListenerDidAdd } = options;
const stack = Stacktrace.create();
let count = 0;
options.onListenerDidAdd = () => {
if (++count === 2) {
console.warn('snapshotted emitter LIKELY used public and SHOULD HAVE BEEN created with DisposableStore. snapshotted here');
stack.print();
}
origListenerDidAdd?.();
};
}
}
/**
* To an event a function with one or zero parameters
@ -125,15 +140,8 @@ export namespace Event {
}
};
if (TRACE_LIKEY_SNAPSHOT_LEAKAGE) {
let stack = Stacktrace.create();
let count = 0;
options.onListenerDidAdd = () => {
if (++count === 2) {
console.warn('snapshotted emitter LIKELY used public and SHOULD HAVE BEEN created with DisposableStore. snapshotted here');
stack.print();
}
};
if (!disposable) {
_addLeakageTraceLogic(options);
}
const emitter = new Emitter<T>(options);
@ -165,7 +173,7 @@ export namespace Event {
let handle: any = undefined;
let numDebouncedCalls = 0;
const emitter = new Emitter<O>({
const options: EmitterOptions | undefined = {
leakWarningThreshold,
onFirstListenerAdd() {
subscription = event(cur => {
@ -193,7 +201,13 @@ export namespace Event {
onLastListenerRemove() {
subscription.dispose();
}
});
};
if (!disposable) {
_addLeakageTraceLogic(options);
}
const emitter = new Emitter<O>(options);
if (disposable) {
disposable.add(emitter);