development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: rename color var for comment input box (#197950)

Browse source 
* chore: rename color var for comment input box

also change the default color to inherit from input.background

* Keep using peekview title background and update editor too

---------

Co-authored-by: Alex Ross <alros@microsoft.com>
This commit is contained in:
Dipta Mahardhika 2023-11-13 14:25:08 +01:00 committed by GitHub
parent 5e27a2845a
commit 6518c0099c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/lib/stylelint/vscode-known-variables.json
View file

@ -180,7 +180,7 @@
"--vscode-editorCodeLens-foreground",
"--vscode-editorCommentsWidget-rangeActiveBackground",
"--vscode-editorCommentsWidget-rangeBackground",
"--vscode-editorCommentsWidget-replyButtonBackground",
"--vscode-editorCommentsWidget-replyInputBackground",
"--vscode-editorCommentsWidget-resolvedBorder",
"--vscode-editorCommentsWidget-unresolvedBorder",
"--vscode-editorCursor-background",

2
src/vs/workbench/contrib/comments/browser/commentColors.ts
View file

@ -13,7 +13,7 @@ import { IColorTheme } from 'vs/platform/theme/common/themeService';
const resolvedCommentViewIcon = registerColor('commentsView.resolvedIcon', { dark: disabledForeground, light: disabledForeground, hcDark: contrastBorder, hcLight: contrastBorder }, nls.localize('resolvedCommentIcon', 'Icon color for resolved comments.'));
const unresolvedCommentViewIcon = registerColor('commentsView.unresolvedIcon', { dark: listFocusOutline, light: listFocusOutline, hcDark: contrastBorder, hcLight: contrastBorder }, nls.localize('unresolvedCommentIcon', 'Icon color for unresolved comments.'));
registerColor('editorCommentsWidget.replyButtonBackground', { dark: peekViewTitleBackground, light: peekViewTitleBackground, hcDark: peekViewTitleBackground, hcLight: peekViewTitleBackground }, nls.localize('commentReplyButtonBackground', 'Background color for comment reply button.'));
registerColor('editorCommentsWidget.replyInputBackground', { dark: peekViewTitleBackground, light: peekViewTitleBackground, hcDark: peekViewTitleBackground, hcLight: peekViewTitleBackground }, nls.localize('commentReplyInputBackground', 'Background color for comment reply input box.'));
const resolvedCommentBorder = registerColor('editorCommentsWidget.resolvedBorder', { dark: resolvedCommentViewIcon, light: resolvedCommentViewIcon, hcDark: contrastBorder, hcLight: contrastBorder }, nls.localize('resolvedCommentBorder', 'Color of borders and arrow for resolved comments.'));
const unresolvedCommentBorder = registerColor('editorCommentsWidget.unresolvedBorder', { dark: unresolvedCommentViewIcon, light: unresolvedCommentViewIcon, hcDark: contrastBorder, hcLight: contrastBorder }, nls.localize('unresolvedCommentBorder', 'Color of borders and arrow for unresolved comments.'));
export const commentThreadRangeBackground = registerColor('editorCommentsWidget.rangeBackground', { dark: transparent(unresolvedCommentBorder, .1), light: transparent(unresolvedCommentBorder, .1), hcDark: transparent(unresolvedCommentBorder, .1), hcLight: transparent(unresolvedCommentBorder, .1) }, nls.localize('commentThreadRangeBackground', 'Color of background for comment ranges.'));

4
src/vs/workbench/contrib/comments/browser/media/review.css
View file

@ -338,7 +338,7 @@
white-space: nowrap;
border: 0px;
outline: 1px solid transparent;
background-color: var(--vscode-editorCommentsWidget-replyButtonBackground);
background-color: var(--vscode-editorCommentsWidget-replyInputBackground);
color: var(--vscode-editor-foreground);
font-size: inherit;
font-family: var(--monaco-monospace-font);
@ -352,7 +352,7 @@
.review-widget .body .comment-form .monaco-editor,
.review-widget .body .comment-form .monaco-editor .monaco-editor-background,
.review-widget .body .edit-container .monaco-editor .monaco-editor-background {
background-color: var(--vscode-peekViewTitle-background);
background-color: var(--vscode-editorCommentsWidget-replyInputBackground);
}
.review-widget .body .comment-form .monaco-editor,