development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

reset last prompted time if skipped

Browse source
This commit is contained in:
Sandeep Somavarapu 2020-09-28 23:07:06 +02:00
parent 44cfd03a4c
commit 64be1b4f68
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/vs/platform/extensionManagement/electron-sandbox/extensionTipsService.ts
View file

@ -198,7 +198,7 @@ export class ExtensionTipsService extends BaseExtensionTipsService {
return;
}
this.updateLastPromptedMediumExeTime();
this.updateLastPromptedMediumExeTime(Date.now());
const [exeName, tips] = [...this.mediumImportanceTipsByExe.entries()][0];
this.promptExeRecommendations(tips)
.then(result => {
@ -207,7 +207,11 @@ export class ExtensionTipsService extends BaseExtensionTipsService {
this.mediumImportanceTipsByExe.delete(exeName);
this.addToRecommendedExecutables(tips[0].exeName, tips);
break;
case RecommendationsNotificationResult.TooMany:
this.updateLastPromptedMediumExeTime(lastPromptedMediumExeTime);
break;
case RecommendationsNotificationResult.Ignored:
this.updateLastPromptedMediumExeTime(lastPromptedMediumExeTime);
this.mediumImportanceExecutableTips.delete(exeName);
break;
}
@ -226,13 +230,13 @@ export class ExtensionTipsService extends BaseExtensionTipsService {
let value = this.storageService.getNumber(lastPromptedMediumImpExeTimeStorageKey, StorageScope.GLOBAL);
if (!value) {
value = Date.now();
this.storageService.store(lastPromptedMediumImpExeTimeStorageKey, value, StorageScope.GLOBAL);
this.updateLastPromptedMediumExeTime(value);
}
return value;
}
private updateLastPromptedMediumExeTime(): void {
this.storageService.store(lastPromptedMediumImpExeTimeStorageKey, Date.now(), StorageScope.GLOBAL);
private updateLastPromptedMediumExeTime(value: number): void {
this.storageService.store(lastPromptedMediumImpExeTimeStorageKey, value, StorageScope.GLOBAL);
}
private getPromptedExecutableTips(): IStringDictionary<string[]> {