mirror of
https://github.com/Microsoft/vscode
synced 2024-10-05 19:02:54 +00:00
Fix some Solarized colors
This PR contains a few fixes for both Solarized themes: 1. According to #105418, the empty scope's foreground color is supposed to be used for normal text. For some reason, this does not seem to work, therefore set `editor.foreground` explicitly. 2. Some of the ANSI colors have been set to values differing from the official theme at https://ethanschoonover.com/solarized/ due to contrast issues. Nowadays, this can instead be fixed with `terminal.integrated.minimumContrastRatio` (see #121107). 3. Solarized Dark uses `#93A1A1` for normal text in a few places where `#839496` should be used instead. 4. Solarized Dark uses `#657B83` in a few places, which is not part of the official theme, use the correct `#586E75` instead. 5. Solarized Light uses `#073642` in one place, which is not part of the official theme, use the correct `#586E75` instead.
This commit is contained in:
parent
7ca80515bd
commit
63917b3d9a
|
@ -3,13 +3,13 @@
|
||||||
"tokenColors": [
|
"tokenColors": [
|
||||||
{
|
{
|
||||||
"settings": {
|
"settings": {
|
||||||
"foreground": "#93A1A1"
|
"foreground": "#839496"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"scope": ["meta.embedded", "source.groovy.embedded"],
|
"scope": ["meta.embedded", "source.groovy.embedded"],
|
||||||
"settings": {
|
"settings": {
|
||||||
"foreground": "#93A1A1"
|
"foreground": "#839496"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
@ -17,7 +17,7 @@
|
||||||
"scope": "comment",
|
"scope": "comment",
|
||||||
"settings": {
|
"settings": {
|
||||||
"fontStyle": "italic",
|
"fontStyle": "italic",
|
||||||
"foreground": "#657B83"
|
"foreground": "#586E75"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
@ -156,7 +156,7 @@
|
||||||
"name": "Tag start/end",
|
"name": "Tag start/end",
|
||||||
"scope": "punctuation.definition.tag",
|
"scope": "punctuation.definition.tag",
|
||||||
"settings": {
|
"settings": {
|
||||||
"foreground": "#657B83"
|
"foreground": "#586E75"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
@ -369,7 +369,7 @@
|
||||||
|
|
||||||
// Editor
|
// Editor
|
||||||
"editor.background": "#002B36",
|
"editor.background": "#002B36",
|
||||||
// "editor.foreground": "#6688cc",
|
"editor.foreground": "#839496",
|
||||||
"editorWidget.background": "#00212B",
|
"editorWidget.background": "#00212B",
|
||||||
"editorCursor.foreground": "#D30102",
|
"editorCursor.foreground": "#D30102",
|
||||||
"editorWhitespace.foreground": "#93A1A180",
|
"editorWhitespace.foreground": "#93A1A180",
|
||||||
|
@ -498,7 +498,7 @@
|
||||||
"terminal.ansiMagenta": "#d33682",
|
"terminal.ansiMagenta": "#d33682",
|
||||||
"terminal.ansiCyan": "#2aa198",
|
"terminal.ansiCyan": "#2aa198",
|
||||||
"terminal.ansiWhite": "#eee8d5",
|
"terminal.ansiWhite": "#eee8d5",
|
||||||
"terminal.ansiBrightBlack": "#586e75",
|
"terminal.ansiBrightBlack": "#002b36",
|
||||||
"terminal.ansiBrightRed": "#cb4b16",
|
"terminal.ansiBrightRed": "#cb4b16",
|
||||||
"terminal.ansiBrightGreen": "#586e75",
|
"terminal.ansiBrightGreen": "#586e75",
|
||||||
"terminal.ansiBrightYellow": "#657b83",
|
"terminal.ansiBrightYellow": "#657b83",
|
||||||
|
|
|
@ -66,7 +66,7 @@
|
||||||
"scope": "storage",
|
"scope": "storage",
|
||||||
"settings": {
|
"settings": {
|
||||||
"fontStyle": "bold",
|
"fontStyle": "bold",
|
||||||
"foreground": "#073642"
|
"foreground": "#586E75"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
@ -361,8 +361,8 @@
|
||||||
// "scrollbarSlider.hoverBackground": "",
|
// "scrollbarSlider.hoverBackground": "",
|
||||||
// Editor
|
// Editor
|
||||||
"editor.background": "#FDF6E3",
|
"editor.background": "#FDF6E3",
|
||||||
|
"editor.foreground": "#657B83",
|
||||||
"notebook.cellEditorBackground": "#F7F0E0",
|
"notebook.cellEditorBackground": "#F7F0E0",
|
||||||
// "editor.foreground": "#6688cc",
|
|
||||||
"editorWidget.background": "#EEE8D5",
|
"editorWidget.background": "#EEE8D5",
|
||||||
"editorCursor.foreground": "#657B83",
|
"editorCursor.foreground": "#657B83",
|
||||||
"editorWhitespace.foreground": "#586E7580",
|
"editorWhitespace.foreground": "#586E7580",
|
||||||
|
@ -480,14 +480,14 @@
|
||||||
"terminal.ansiMagenta": "#d33682",
|
"terminal.ansiMagenta": "#d33682",
|
||||||
"terminal.ansiCyan": "#2aa198",
|
"terminal.ansiCyan": "#2aa198",
|
||||||
"terminal.ansiWhite": "#eee8d5",
|
"terminal.ansiWhite": "#eee8d5",
|
||||||
"terminal.ansiBrightBlack": "#586e75",
|
"terminal.ansiBrightBlack": "#002b36",
|
||||||
"terminal.ansiBrightRed": "#cb4b16",
|
"terminal.ansiBrightRed": "#cb4b16",
|
||||||
"terminal.ansiBrightGreen": "#586e75",
|
"terminal.ansiBrightGreen": "#586e75",
|
||||||
"terminal.ansiBrightYellow": "#657b83",
|
"terminal.ansiBrightYellow": "#657b83",
|
||||||
"terminal.ansiBrightBlue": "#839496",
|
"terminal.ansiBrightBlue": "#839496",
|
||||||
"terminal.ansiBrightMagenta": "#6c71c4",
|
"terminal.ansiBrightMagenta": "#6c71c4",
|
||||||
"terminal.ansiBrightCyan": "#93a1a1",
|
"terminal.ansiBrightCyan": "#93a1a1",
|
||||||
"terminal.ansiBrightWhite": "#eee8d5",
|
"terminal.ansiBrightWhite": "#fdf6e3",
|
||||||
// Interactive Playground
|
// Interactive Playground
|
||||||
"walkThrough.embeddedEditorBackground": "#00000014"
|
"walkThrough.embeddedEditorBackground": "#00000014"
|
||||||
},
|
},
|
||||||
|
|
Loading…
Reference in a new issue