prevent empty markdown string from appearing in the hover (#168168)

fixes https://github.com/microsoft/vscode/issues/162227#issuecomment-1337563966
This commit is contained in:
Johannes Rieken 2022-12-06 14:34:20 +01:00 committed by GitHub
parent 37a74f9e41
commit 62d8f662fb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -212,7 +212,7 @@ export class GotoDefinitionAtPositionEditorContribution implements IEditorContri
const languageId = this.languageService.guessLanguageIdByFilepathOrFirstLine(textEditorModel.uri);
this.addDecoration(
linkRange,
new MarkdownString().appendCodeblock(languageId ? languageId : '', previewValue)
previewValue ? new MarkdownString().appendCodeblock(languageId ? languageId : '', previewValue) : undefined
);
ref.dispose();
});
@ -260,7 +260,7 @@ export class GotoDefinitionAtPositionEditorContribution implements IEditorContri
return new Range(startLineNumber, 1, endLineNumber + 1, 1);
}
private addDecoration(range: Range, hoverMessage: MarkdownString): void {
private addDecoration(range: Range, hoverMessage: MarkdownString | undefined): void {
const newDecorations: IModelDeltaDecoration = {
range: range,