development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-30 11:10:48 +00:00
Code Issues Projects Releases Packages Wiki Activity

add an API proposal for DocumentFilter#notebookType, https://github.com/microsoft/vscode/issues/141143

Browse source
This commit is contained in:
Johannes Rieken 2022-02-10 17:02:40 +01:00
parent b239683e79
commit 609eea3a30
No known key found for this signature in database
GPG key ID: 96634B5AF12F8798
5 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/vs/workbench/api/common/extHost.api.impl.ts
View file

@ -223,6 +223,9 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
if (typeof filter.exclusive === 'boolean') {
checkProposedApiEnabled(extension, 'documentFiltersExclusive');
}
if (typeof filter.notebookType === 'string') {
checkProposedApiEnabled(extension, 'notebookDocumentSelector');
}
}
return selector;
};

1
src/vs/workbench/api/common/extHost.protocol.ts
View file

@ -336,6 +336,7 @@ export interface IDocumentFilterDto {
scheme?: string;
pattern?: string | IRelativePattern;
exclusive?: boolean;
notebookType?: string;
}
export interface ISignatureHelpProviderMetadataDto {

3
src/vs/workbench/api/common/extHostTypeConverters.ts
View file

@ -148,7 +148,8 @@ export namespace DocumentSelector {
language: selector.language,
scheme: _transformScheme(selector.scheme, uriTransformer),
pattern: GlobPattern.from(selector.pattern) ?? undefined,
exclusive: selector.exclusive
exclusive: selector.exclusive,
notebookType: selector.notebookType
};
}

1
src/vs/workbench/services/extensions/common/extensionsApiProposals.ts
View file

@ -34,6 +34,7 @@ export const allApiProposals = Object.freeze({
notebookControllerKind: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookControllerKind.d.ts',
notebookDebugOptions: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookDebugOptions.d.ts',
notebookDeprecated: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookDeprecated.d.ts',
notebookDocumentSelector: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookDocumentSelector.d.ts',
notebookEditor: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookEditor.d.ts',
notebookEditorDecorationType: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookEditorDecorationType.d.ts',
notebookEditorEdit: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.notebookEditorEdit.d.ts',

17
src/vscode-dts/vscode.proposed.notebookDocumentSelector.d.ts vendored Normal file
View file

@ -0,0 +1,17 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
declare module 'vscode' {
// https://github.com/microsoft/vscode/issues/141143
export interface DocumentFilter {
/**
* The {@link NotebookDocument.notebookType type} of a notebook, like `jupyter`
*/
readonly notebookType?: string;
}
}