From 5efc2a498a823d873513e6fabf195b866fd54965 Mon Sep 17 00:00:00 2001
From: Don Jayamanne <don.jayamanne@outlook.com>
Date: Fri, 27 Jan 2023 08:24:22 +1100
Subject: [PATCH] Localize ipynb extension commands (#172272)

* Localize ipynb extension commands

* More updates
---
 extensions/ipynb/package.json     | 13 ++++++-------
 extensions/ipynb/package.nls.json |  7 ++++++-
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/extensions/ipynb/package.json b/extensions/ipynb/package.json
index 95dc152d631..2963e0295aa 100644
--- a/extensions/ipynb/package.json
+++ b/extensions/ipynb/package.json
@@ -13,8 +13,7 @@
 		"diffContentOptions"
 	],
 	"activationEvents": [
-		"onNotebook:jupyter-notebook",
-		"onCommand:ipynb.newUntitledIpynb"
+		"onNotebook:jupyter-notebook"
 	],
 	"extensionKind": [
 		"workspace",
@@ -44,17 +43,17 @@
 		"commands": [
 			{
 				"command": "ipynb.newUntitledIpynb",
-				"title": "New Jupyter Notebook",
-				"shortTitle": "Jupyter Notebook",
+				"title": "%newUntitledIpynb.title%",
+				"shortTitle": "%newUntitledIpynb.shortTitle%",
 				"category": "Create"
 			},
 			{
 				"command": "ipynb.openIpynbInNotebookEditor",
-				"title": "Open ipynb file in notebook editor"
+				"title": "%openIpynbInNotebookEditor.title%"
 			},
 			{
 				"command": "ipynb.cleanInvalidImageAttachment",
-				"title": "Clean invalid image attachment reference"
+				"title": "%cleanInvalidImageAttachment.title%"
 			}
 		],
 		"notebooks": [
@@ -72,7 +71,7 @@
 		"notebookRenderer": [
 			{
 				"id": "vscode.markdown-it-cell-attachment-renderer",
-				"displayName": "Markdown it ipynb Cell Attachment renderer",
+				"displayName": "%markdownAttachmentRenderer.displayName%",
 				"entrypoint": {
 					"extends": "vscode.markdown-it-renderer",
 					"path": "./notebook-out/cellAttachmentRenderer.js"
diff --git a/extensions/ipynb/package.nls.json b/extensions/ipynb/package.nls.json
index 1c8f73370d7..5fead32a38b 100644
--- a/extensions/ipynb/package.nls.json
+++ b/extensions/ipynb/package.nls.json
@@ -1,5 +1,10 @@
 {
 	"displayName": ".ipynb Support",
 	"description": "Provides basic support for opening and reading Jupyter's .ipynb notebook files",
-	"ipynb.pasteImagesAsAttachments.enabled": "Enable/disable pasting of images into Markdown cells in ipynb notebook files. Pasted images are inserted as attachments to the cell."
+	"ipynb.pasteImagesAsAttachments.enabled": "Enable/disable pasting of images into Markdown cells in ipynb notebook files. Pasted images are inserted as attachments to the cell.",
+	"newUntitledIpynb.title": "New Jupyter Notebook",
+	"newUntitledIpynb.shortTitle": "Jupyter Notebook",
+	"openIpynbInNotebookEditor.title": "Open IPYNB File In Notebook Editor",
+	"cleanInvalidImageAttachment.title": "Clean Invalid Image Attachment Reference",
+	"markdownAttachmentRenderer.displayName": "Markdown it ipynb Cell Attachment renderer"
 }