development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-12 22:37:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only update visibilities when visible (#84125)

Browse source
This commit is contained in:
Christof Marti 2019-11-12 14:40:07 +01:00
parent cd39e8e0a2
commit 57ddcfd792
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/vs/workbench/browser/parts/quickinput/quickInput.ts
View file

@ -702,11 +702,11 @@ class QuickPick<T extends IQuickPickItem> extends QuickInput implements IQuickPi
}
protected update() {
this.ui.setVisibilities(this.canSelectMany ? { title: !!this.title || !!this.step, checkAll: true, inputBox: true, visibleCount: true, count: true, ok: true, list: true, message: !!this.validationMessage } : { title: !!this.title || !!this.step, inputBox: true, visibleCount: true, list: true, message: !!this.validationMessage, customButton: this.customButton, ok: this.ok });
super.update();
if (!this.visible) {
return;
}
this.ui.setVisibilities(this.canSelectMany ? { title: !!this.title || !!this.step, checkAll: true, inputBox: true, visibleCount: true, count: true, ok: true, list: true, message: !!this.validationMessage } : { title: !!this.title || !!this.step, inputBox: true, visibleCount: true, list: true, message: !!this.validationMessage, customButton: this.customButton, ok: this.ok });
super.update();
if (this.ui.inputBox.value !== this.value) {
this.ui.inputBox.value = this.value;
}
@ -860,11 +860,11 @@ class InputBox extends QuickInput implements IInputBox {
}
protected update() {
this.ui.setVisibilities({ title: !!this.title || !!this.step, inputBox: true, message: true });
super.update();
if (!this.visible) {
return;
}
this.ui.setVisibilities({ title: !!this.title || !!this.step, inputBox: true, message: true });
super.update();
if (this.ui.inputBox.value !== this.value) {
this.ui.inputBox.value = this.value;
}