development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Pass TS Server the original fs path (#177292)

Browse source 
For #177083

We've had code to normalize the file path for a long time but I don't think it's needed. In the case of samba paths, it also appears to break things

Let's try dropping it and passing along the original `fsPath` instead
This commit is contained in:
Matt Bierner 2023-03-15 15:00:15 -07:00 committed by GitHub
parent 3e5253b143
commit 54921d7173
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
extensions/typescript-language-features/src/typescriptServiceClient.ts
View file

@ -697,12 +697,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
}
if (resource.scheme === fileSchemes.file && !isWeb()) {
if (!resource.fsPath) {
return undefined;
}
// Convert to posix style path
return path.posix.normalize(resource.fsPath.split(path.sep).join(path.posix.sep));
return resource.fsPath;
}
return (this.isProjectWideIntellisenseOnWebEnabled() ? '' : this.inMemoryResourcePrefix)