development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 21:55:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

let -> const, settings

Browse source
This commit is contained in:
Rob Lourens 2020-08-02 09:14:42 -07:00
parent 91e21b5940
commit 518523fc7f
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extensions/configuration-editing/src/settingsDocumentHelper.ts
View file

@ -223,7 +223,7 @@ export class SettingsDocument {
if (location.path.length === 1 && location.previousNode && typeof location.previousNode.value === 'string' && location.previousNode.value.startsWith('[')) { if (location.path.length === 1 && location.previousNode && typeof location.previousNode.value === 'string' && location.previousNode.value.startsWith('[')) {
// Suggestion model word matching includes closed sqaure bracket and ending quote // Suggestion model word matching includes closed sqaure bracket and ending quote
// Hence include them in the proposal to replace // Hence include them in the proposal to replace
let range = this.document.getWordRangeAtPosition(position) || new vscode.Range(position, position); const range = this.document.getWordRangeAtPosition(position) || new vscode.Range(position, position);
return this.provideLanguageCompletionItemsForLanguageOverrides(location, range, language => `"[${language}]"`); return this.provideLanguageCompletionItemsForLanguageOverrides(location, range, language => `"[${language}]"`);
} }
return Promise.resolve([]); return Promise.resolve([]);

2
src/vs/workbench/contrib/preferences/browser/settingsTree.ts
View file

@ -1071,7 +1071,7 @@ export class SettingObjectRenderer extends AbstractSettingRenderer implements IT
: {}; : {};
const newValue: Record<string, unknown> = {}; const newValue: Record<string, unknown> = {};
let newItems: IObjectDataItem[] = []; const newItems: IObjectDataItem[] = [];
template.objectWidget.items.forEach((item, idx) => { template.objectWidget.items.forEach((item, idx) => {
// Item was updated // Item was updated

6
src/vs/workbench/contrib/preferences/browser/settingsTreeModels.ts
View file

@ -424,7 +424,7 @@ function wordifyKey(key: string): string {
match; match;
}); });
for (let [k, v] of knownTermMappings) { for (const [k, v] of knownTermMappings) {
key = key.replace(new RegExp(`\\b${k}\\b`, 'gi'), v); key = key.replace(new RegExp(`\\b${k}\\b`, 'gi'), v);
} }
@ -631,7 +631,7 @@ const tagRegex = /(^|\s)@tag:("([^"]*)"|[^"]\S*)/g;
const extensionRegex = /(^|\s)@ext:("([^"]*)"|[^"]\S*)?/g; const extensionRegex = /(^|\s)@ext:("([^"]*)"|[^"]\S*)?/g;
export function parseQuery(query: string): IParsedQuery { export function parseQuery(query: string): IParsedQuery {
const tags: string[] = []; const tags: string[] = [];
let extensions: string[] = []; const extensions: string[] = [];
query = query.replace(tagRegex, (_, __, quotedTag, tag) => { query = query.replace(tagRegex, (_, __, quotedTag, tag) => {
tags.push(tag || quotedTag); tags.push(tag || quotedTag);
return ''; return '';
@ -643,7 +643,7 @@ export function parseQuery(query: string): IParsedQuery {
}); });
query = query.replace(extensionRegex, (_, __, quotedExtensionId, extensionId) => { query = query.replace(extensionRegex, (_, __, quotedExtensionId, extensionId) => {
let extensionIdQuery: string = extensionId || quotedExtensionId; const extensionIdQuery: string = extensionId || quotedExtensionId;
if (extensionIdQuery) { if (extensionIdQuery) {
extensions.push(...extensionIdQuery.split(',').map(s => s.trim()).filter(s => !isFalsyOrWhitespace(s))); extensions.push(...extensionIdQuery.split(',').map(s => s.trim()).filter(s => !isFalsyOrWhitespace(s)));
} }