development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

on blur of terminal chat widget, if terminal is not visible, hide it (#212747)

Browse source 
fix #212672
This commit is contained in:
Megan Rogge 2024-05-14 15:34:17 -07:00 committed by GitHub
parent e3c1bbc90d
commit 4d03498fcd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/vs/workbench/contrib/terminal/browser/terminal.ts
View file

@ -639,6 +639,11 @@ export interface ITerminalInstance extends IBaseTerminalInstance {
*/
readonly isDisposed: boolean;
/**
* Whether this terminal is visible.
*/
readonly isVisible: boolean;
/**
* Whether the terminal's pty is hosted on a remote.
*/

1
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
View file

@ -266,6 +266,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
get isRemote(): boolean { return this._processManager.remoteAuthority !== undefined; }
get remoteAuthority(): string | undefined { return this._processManager.remoteAuthority; }
get hasFocus(): boolean { return dom.isAncestorOfActiveElement(this._wrapperElement); }
get isVisible(): boolean { return this._isVisible; }
get title(): string { return this._title; }
get titleSource(): TitleEventSource { return this._titleSource; }
get icon(): TerminalIcon | undefined { return this._getIcon(); }

5
src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatWidget.ts
View file

@ -91,6 +91,11 @@ export class TerminalChatWidget extends Disposable {
this._container.appendChild(this._inlineChatWidget.domNode);
this._focusTracker = this._register(trackFocus(this._container));
this._register(this._focusTracker.onDidBlur(() => {
if (!this._instance.isVisible) {
this.hide();
}
}));
this.hide();
}