development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-07-02 15:59:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

testing: fix confusing line decorations when hovering over line numbers (#214275)

Browse Source 
Fixes #212585
This commit is contained in:
Connor Peet 2024-06-04 14:18:21 -07:00 committed by GitHub
parent ad4f719bd5
commit 4af0c6a8f4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/vs/workbench/contrib/testing/browser/codeCoverageDecorations.ts
View File

@ -51,7 +51,6 @@ import { ITestService } from 'vs/workbench/contrib/testing/common/testService';
import { CoverageDetails, DetailType, IDeclarationCoverage, IStatementCoverage } from 'vs/workbench/contrib/testing/common/testTypes';
import { TestingContextKeys } from 'vs/workbench/contrib/testing/common/testingContextKeys';
const MAX_HOVERED_LINES = 30;
const CLASS_HIT = 'coverage-deco-hit';
const CLASS_MISS = 'coverage-deco-miss';
const TOGGLE_INLINE_COMMAND_TEXT = localize('testing.toggleInlineCoverage', 'Toggle Inline');
@ -213,9 +212,14 @@ export class CodeCoverageDecorations extends Disposable implements IEditorContri
const todo = [{ line: lineNumber, dir: 0 }];
const toEnable = new Set<string>();
const ranges = this.editor.getVisibleRanges();
if (!this.coverage.showInline.get()) {
for (let i = 0; i < todo.length && i < MAX_HOVERED_LINES; i++) {
for (let i = 0; i < todo.length; i++) {
const { line, dir } = todo[i];
if (!ranges.some(r => r.startLineNumber <= line && r.endLineNumber >= line)) {
continue; // stop once outside the viewport
}
let found = false;
for (const decoration of model.getLineDecorations(line)) {
if (this.decorationIds.has(decoration.id)) {