This commit is contained in:
rebornix 2020-09-24 15:10:37 -07:00
parent 97af4fb370
commit 42e97f3c0a
2 changed files with 4 additions and 2 deletions

View file

@ -349,7 +349,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
.map(pattern => typeConverters.NotebookExclusiveDocumentPattern.from(pattern))
.filter(pattern => pattern !== undefined) as (string | IRelativePattern | INotebookExclusiveDocumentFilter)[];
if (!viewOptionsFilenamePattern) {
if (options?.viewOptions?.filenamePattern && !viewOptionsFilenamePattern) {
console.warn(`Notebook content provider view options file name pattern is invalid ${options?.viewOptions?.filenamePattern}`);
}

View file

@ -815,7 +815,9 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditor
|| kernelsFromSameExtension.find(kernel => kernel.id === cachedKernelId)
|| kernelsFromSameExtension[0];
this.activeKernel = preferedKernel;
if (this.activeKernel) {
await this._loadKernelPreloads(this.activeKernel.extensionLocation, this.activeKernel);
}
if (tokenSource.token.isCancellationRequested) {
return;