development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 21:55:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

debt - ensure to close state service (#192850)

Browse source
This commit is contained in:
Benjamin Pasero 2023-09-12 10:49:08 +02:00 committed by GitHub
parent bbbd8da393
commit 41c6343f84
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/vs/platform/state/test/node/state.test.ts
View file

@ -170,6 +170,8 @@ flakySuite('StateService', () => {
assert.strictEqual(service.getItem('some.setItems.key3'), undefined);
assert.strictEqual(service.getItem('some.setItems.key4'), undefined);
assert.strictEqual(service.getItem('some.setItems.key5'), undefined);
return service.close();
});
test('Multiple ops are buffered and applied', async function () {
@ -199,6 +201,8 @@ flakySuite('StateService', () => {
assert.strictEqual(service.getItem('some.key2'), 'some.value2');
assert.strictEqual(service.getItem('some.key3'), 'some.value3');
assert.strictEqual(service.getItem('some.key4'), undefined);
return service.close();
});
test('Multiple ops (Immediate Strategy)', async function () {
@ -228,6 +232,8 @@ flakySuite('StateService', () => {
assert.strictEqual(service.getItem('some.key2'), 'some.value2');
assert.strictEqual(service.getItem('some.key3'), 'some.value3');
assert.strictEqual(service.getItem('some.key4'), undefined);
return service.close();
});
test('Used before init', async function () {
@ -253,6 +259,8 @@ flakySuite('StateService', () => {
assert.strictEqual(service.getItem('some.key2'), 'some.value2');
assert.strictEqual(service.getItem('some.key3'), 'some.value3');
assert.strictEqual(service.getItem('some.key4'), undefined);
return service.close();
});
test('Used after close', async function () {
@ -276,7 +284,7 @@ flakySuite('StateService', () => {
assert.ok(contents.includes('some.value1'));
assert.ok(!contents.includes('some.marker'));
await service.close();
return service.close();
});
test('Closed before init', async function () {