development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only fire one event when selectedItems is set (#208853)

Browse source 
Fixes https://github.com/microsoft/vscode/issues/208605
This commit is contained in:
Tyler James Leonhardt 2024-03-26 19:59:11 -07:00 committed by GitHub
parent 34e0d29439
commit 3ff48780d3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 44 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

63
src/vs/platform/quickinput/browser/quickInputTree.ts
View file

@ -707,6 +707,10 @@ export class QuickInputTree extends Disposable {
// Elements that apply to the current set of elements
private _elementDisposable = this._register(new DisposableStore());
private _lastHover: IHoverWidget | undefined;
// This is used to prevent setting the checked state of a single element from firing the checked events
// so that we can batch them together. This can probably be improved by handling events differently,
// but this works for now. An observable would probably be ideal for this.
private _shouldFireCheckedEvents = true;
constructor(
private parent: HTMLElement,
@ -1056,12 +1060,18 @@ export class QuickInputTree extends Disposable {
}
setAllVisibleChecked(checked: boolean) {
this._itemElements.forEach(element => {
if (!element.hidden && !element.checkboxDisabled) {
element.checked = checked;
}
});
this._fireCheckedEvents();
try {
this._shouldFireCheckedEvents = false;
this._itemElements.forEach(element => {
if (!element.hidden && !element.checkboxDisabled) {
// Would fire an event if we didn't have the flag set
element.checked = checked;
}
});
} finally {
this._shouldFireCheckedEvents = true;
this._fireCheckedEvents();
}
}
setElements(inputElements: QuickPickItem[]): void {
@ -1185,14 +1195,20 @@ export class QuickInputTree extends Disposable {
}
setCheckedElements(items: IQuickPickItem[]) {
const checked = new Set();
for (const item of items) {
checked.add(item);
try {
this._shouldFireCheckedEvents = false;
const checked = new Set();
for (const item of items) {
checked.add(item);
}
for (const element of this._itemElements) {
// Would fire an event if we didn't have the flag set
element.checked = checked.has(element.item);
}
} finally {
this._shouldFireCheckedEvents = true;
this._fireCheckedEvents();
}
for (const element of this._itemElements) {
element.checked = checked.has(element.item);
}
this._fireCheckedEvents();
}
focus(what: QuickInputListFocus): void {
@ -1498,14 +1514,20 @@ export class QuickInputTree extends Disposable {
}
toggleCheckbox() {
const elements = this._tree.getFocus().filter((e): e is QuickPickItemElement => e instanceof QuickPickItemElement);
const allChecked = this._allVisibleChecked(elements);
for (const element of elements) {
if (!element.checkboxDisabled) {
element.checked = !allChecked;
try {
this._shouldFireCheckedEvents = false;
const elements = this._tree.getFocus().filter((e): e is QuickPickItemElement => e instanceof QuickPickItemElement);
const allChecked = this._allVisibleChecked(elements);
for (const element of elements) {
if (!element.checkboxDisabled) {
// Would fire an event if we didn't have the flag set
element.checked = !allChecked;
}
}
} finally {
this._shouldFireCheckedEvents = true;
this._fireCheckedEvents();
}
this._fireCheckedEvents();
}
display(display: boolean) {
@ -1565,6 +1587,9 @@ export class QuickInputTree extends Disposable {
}
private _fireCheckedEvents() {
if (!this._shouldFireCheckedEvents) {
return;
}
this._onChangedAllVisibleChecked.fire(this.getAllVisibleChecked());
this._onChangedCheckedCount.fire(this.getCheckedCount());
this._onChangedCheckedElements.fire(this.getCheckedElements());