development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-02 17:32:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor hover delegate assignments (#205366)

Browse source 
💄
This commit is contained in:
Benjamin Christopher Simmonds 2024-02-16 14:54:39 +01:00 committed by GitHub
parent d9ef55ae9e
commit 3fdb0fa6e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/vs/base/browser/ui/actionbar/actionViewItems.ts
View file

@ -226,7 +226,6 @@ export class BaseActionViewItem extends Disposable implements IActionViewItem {
const title = this.getTooltip() ?? '';
this.updateAriaLabel();
this.element.title = '';
if (!this.customHover) {
const hoverDelegate = this.options.hoverDelegate ?? getDefaultHoverDelegate('element');
this.customHover = setupCustomHover(hoverDelegate, this.element, title);

2
src/vs/platform/quickinput/browser/quickInputService.ts
View file

@ -90,7 +90,7 @@ export class QuickInputService extends Themable implements IQuickInputService {
options: IWorkbenchListOptions<T>
) => this.instantiationService.createInstance(WorkbenchList, user, container, delegate, renderers, options) as List<T>,
styles: this.computeStyles(),
hoverDelegate: this.instantiationService.createInstance(QuickInputHoverDelegate)
hoverDelegate: this._register(this.instantiationService.createInstance(QuickInputHoverDelegate))
};
const controller = this._register(new QuickInputController({

2
src/vs/workbench/contrib/remote/browser/tunnelView.ts
View file

@ -355,7 +355,7 @@ class ActionBarRenderer extends Disposable implements ITableRenderer<ActionBarCe
) {
super();
this._hoverDelegate = getDefaultHoverDelegate('mouse', true);
this._hoverDelegate = this._register(getDefaultHoverDelegate('mouse', true));
}
set actionRunner(actionRunner: ActionRunner) {

2
src/vs/workbench/contrib/timeline/browser/timelinePane.ts
View file

@ -1149,7 +1149,7 @@ class TimelineTreeRenderer implements ITreeRenderer<TreeElement, FuzzyScore, Tim
@IThemeService private themeService: IThemeService,
) {
this.actionViewItemProvider = createActionViewItem.bind(undefined, this.instantiationService);
this._hoverDelegate = getDefaultHoverDelegate('element');
this._hoverDelegate = getDefaultHoverDelegate('mouse');
}
private uri: URI | undefined;