From 70066263746b9e5f5f0eebe28ee9b68303482dee Mon Sep 17 00:00:00 2001 From: Jon Bockhorst Date: Wed, 17 Apr 2019 10:46:31 -0500 Subject: [PATCH 1/2] Fixed explorer modified sort order not working sometimes --- src/vs/workbench/contrib/files/common/explorerService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/files/common/explorerService.ts b/src/vs/workbench/contrib/files/common/explorerService.ts index 0e3b5d1dc1d..7dc8a0712bd 100644 --- a/src/vs/workbench/contrib/files/common/explorerService.ts +++ b/src/vs/workbench/contrib/files/common/explorerService.ts @@ -155,7 +155,7 @@ export class ExplorerService implements IExplorerService { } // Stat needs to be resolved first and then revealed - const options: IResolveFileOptions = { resolveTo: [resource], resolveMetadata: false }; + const options: IResolveFileOptions = { resolveTo: [resource], resolveMetadata: this.sortOrder === 'modified' ? true : false }; const workspaceFolder = this.contextService.getWorkspaceFolder(resource); const rootUri = workspaceFolder ? workspaceFolder.uri : this.roots[0].resource; const root = this.roots.filter(r => r.resource.toString() === rootUri.toString()).pop()!; From 14f982adbf5bfaa8e1c0bec0e3929fed88dff362 Mon Sep 17 00:00:00 2001 From: Gonzalo D'Elia Date: Tue, 23 Apr 2019 08:10:51 -0500 Subject: [PATCH 2/2] Update src/vs/workbench/contrib/files/common/explorerService.ts Co-Authored-By: jmbockhorst <44308390+jmbockhorst@users.noreply.github.com> --- src/vs/workbench/contrib/files/common/explorerService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/files/common/explorerService.ts b/src/vs/workbench/contrib/files/common/explorerService.ts index 7dc8a0712bd..6bec4dbd5da 100644 --- a/src/vs/workbench/contrib/files/common/explorerService.ts +++ b/src/vs/workbench/contrib/files/common/explorerService.ts @@ -155,7 +155,7 @@ export class ExplorerService implements IExplorerService { } // Stat needs to be resolved first and then revealed - const options: IResolveFileOptions = { resolveTo: [resource], resolveMetadata: this.sortOrder === 'modified' ? true : false }; + const options: IResolveFileOptions = { resolveTo: [resource], resolveMetadata: this.sortOrder === 'modified' }; const workspaceFolder = this.contextService.getWorkspaceFolder(resource); const rootUri = workspaceFolder ? workspaceFolder.uri : this.roots[0].resource; const root = this.roots.filter(r => r.resource.toString() === rootUri.toString()).pop()!;