development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use locale string for number renderer (#170896)

Browse source
This commit is contained in:
Raymond Zhao 2023-01-09 12:06:56 -08:00 committed by GitHub
parent c9acedb686
commit 3cf2588d06
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/vs/workbench/contrib/preferences/browser/settingsTree.ts
View file

@ -22,7 +22,7 @@ import { onUnexpectedError } from 'vs/base/common/errors';
import { Emitter, Event } from 'vs/base/common/event';
import { KeyCode } from 'vs/base/common/keyCodes';
import { Disposable, DisposableStore, dispose, isDisposable, toDisposable } from 'vs/base/common/lifecycle';
import { isIOS } from 'vs/base/common/platform';
import { isIOS, language } from 'vs/base/common/platform';
import { escapeRegExpCharacters } from 'vs/base/common/strings';
import { isDefined, isUndefinedOrNull } from 'vs/base/common/types';
import { localize } from 'vs/nls';
@ -1757,7 +1757,8 @@ export class SettingNumberRenderer extends AbstractSettingRenderer implements IT
? ((v: string) => v === '' ? null : numParseFn(v)) : numParseFn;
template.onChange = undefined;
template.inputBox.value = dataElement.value;
template.inputBox.value = typeof dataElement.value === 'number' ?
dataElement.value.toLocaleString(language) : '';
template.inputBox.step = dataElement.valueType.includes('integer') ? '1' : 'any';
template.inputBox.setAriaLabel(dataElement.setting.key);
template.onChange = value => {