development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not offer 'Create file' option for readonly file systems (fix #203223) (#203234)

Browse source
This commit is contained in:
Benjamin Pasero 2024-01-23 21:18:54 +01:00 committed by GitHub
parent ca476115d3
commit 3cf1815508
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/vs/workbench/contrib/files/browser/editors/textFileEditor.ts
View file

@ -36,6 +36,7 @@ import { IConfigurationService } from 'vs/platform/configuration/common/configur
import { IPreferencesService } from 'vs/workbench/services/preferences/common/preferences';
import { IHostService } from 'vs/workbench/services/host/browser/host';
import { IEditorOptions as ICodeEditorOptions } from 'vs/editor/common/config/editorOptions';
import { IFilesConfigurationService } from 'vs/workbench/services/filesConfiguration/common/filesConfigurationService';
/**
* An implementation of editor for file system resources.
@ -61,7 +62,8 @@ export class TextFileEditor extends AbstractTextCodeEditor<ICodeEditorViewState>
@IPathService private readonly pathService: IPathService,
@IConfigurationService private readonly configurationService: IConfigurationService,
@IPreferencesService protected readonly preferencesService: IPreferencesService,
@IHostService private readonly hostService: IHostService
@IHostService private readonly hostService: IHostService,
@IFilesConfigurationService private readonly filesConfigurationService: IFilesConfigurationService
) {
super(TextFileEditor.ID, telemetryService, instantiationService, storageService, textResourceConfigurationService, themeService, editorService, editorGroupService, fileService);
@ -201,8 +203,12 @@ export class TextFileEditor extends AbstractTextCodeEditor<ICodeEditorViewState>
throw createTooLargeFileError(this.group, input, options, message, this.preferencesService);
}
// Offer to create a file from the error if we have a file not found and the name is valid
if ((<FileOperationError>error).fileOperationResult === FileOperationResult.FILE_NOT_FOUND && await this.pathService.hasValidBasename(input.preferredResource)) {
// Offer to create a file from the error if we have a file not found and the name is valid and not readonly
if (
(<FileOperationError>error).fileOperationResult === FileOperationResult.FILE_NOT_FOUND &&
!this.filesConfigurationService.isReadonly(input.preferredResource) &&
await this.pathService.hasValidBasename(input.preferredResource)
) {
const fileNotFoundError = createEditorOpenError(new FileOperationError(localize('unavailableResourceErrorEditorText', "The editor could not be opened because the file was not found."), FileOperationResult.FILE_NOT_FOUND), [
toAction({
id: 'workbench.files.action.createMissingFile', label: localize('createFile', "Create File"), run: async () => {