development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Still gray out vars even if user has disabled suggestions

Browse source 
Fixes #50890
This commit is contained in:
Matt Bierner 2018-05-31 11:56:50 -07:00
parent 015ec8303c
commit 3c11a065e7
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
extensions/typescript-language-features/src/features/diagnostics.ts
View file

@ -156,10 +156,12 @@ export class DiagnosticsManager {
}
private getSuggestionDiagnostics(file: vscode.Uri) {
if (!this._enableSuggestions) {
return [];
}
return this._diagnostics.get(DiagnosticKind.Suggestion)!.get(file);
return this._diagnostics.get(DiagnosticKind.Suggestion)!.get(file).filter(x => {
if (!this._enableSuggestions) {
// Still show unused
return x.customTags && x.customTags.indexOf(vscode.DiagnosticTag.Unnecessary) !== -1;
}
return true;
});
}
}