development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add extra guard on restarting TS server on fatal crash

Browse source
This commit is contained in:
Matt Bierner 2020-02-24 15:12:53 -08:00
parent 6ff3d9c899
commit 3c030d7014
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
extensions/typescript-language-features/src/typescriptServiceClient.ts
View file

@ -109,6 +109,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
private lastStart: number;
private numberRestarts: number;
private isRestarting: boolean = false;
private hasServerFatallyCrashedTooManyTimes = false;
private readonly loadingIndicator = new ServerInitializingIndicator();
public readonly telemetryReporter: TelemetryReporter;
@ -306,7 +307,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
private token: number = 0;
private startService(resendModels: boolean = false): ServerState.State {
if (this.isDisposed) {
if (this.isDisposed || this.hasServerFatallyCrashedTooManyTimes) {
return ServerState.None;
}
@ -542,6 +543,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
if (diff < 10 * 1000 /* 10 seconds */) {
this.lastStart = Date.now();
startService = false;
this.hasServerFatallyCrashedTooManyTimes = true;
prompt = vscode.window.showErrorMessage<MyMessageItem>(
localize('serverDiedAfterStart', 'The TypeScript language service died 5 times right after it got started. The service will not be restarted.'),
{