development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

voice - fix hold mode in presence of lazy activation (#208884)

Browse source
This commit is contained in:
Benjamin Pasero 2024-03-27 11:15:11 +01:00 committed by GitHub
parent 298c42a605
commit 3a3c5c4b1c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts
View file

@ -462,22 +462,18 @@ async function startVoiceChatWithHoldMode(id: string, accessor: ServicesAccessor
const holdMode = keybindingService.enableKeybindingHoldMode(id);
let session: IVoiceChatSession | undefined = undefined;
const controller = await VoiceChatSessionControllerFactory.create(accessor, target);
if (!controller) {
return;
}
const session = await VoiceChatSessions.getInstance(instantiationService).start(controller, context);
let acceptVoice = false;
const handle = disposableTimeout(() => {
acceptVoice = true;
session?.setTimeoutDisabled(true); // disable accept on timeout when hold mode runs for VOICE_KEY_HOLD_THRESHOLD
}, VOICE_KEY_HOLD_THRESHOLD);
const controller = await VoiceChatSessionControllerFactory.create(accessor, target);
if (!controller) {
handle.dispose();
return;
}
session = await VoiceChatSessions.getInstance(instantiationService).start(controller, context);
await holdMode;
handle.dispose();