development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf - fix counting of major GCs (#214016)

Browse source
This commit is contained in:
Benjamin Pasero 2024-05-31 16:51:30 +02:00 committed by GitHub
parent aaa5cb462e
commit 3a1ad5f077
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/vs/workbench/contrib/performance/electron-sandbox/startupTimings.ts
View file

@ -179,11 +179,9 @@ export class NativeStartupTimings extends StartupTimings implements IWorkbenchCo
// Major/Minor GC Events
case 'MinorGC':
minorGCs++;
break;
case 'MajorGC':
majorGCs++;
if (event.args && typeof event.args.usedHeapSizeAfter === 'number' && typeof event.args.usedHeapSizeBefore === 'number') {
garbage += (event.args.usedHeapSizeBefore - event.args.usedHeapSizeAfter);
}
break;
// GC Events that block the main thread
@ -193,6 +191,12 @@ export class NativeStartupTimings extends StartupTimings implements IWorkbenchCo
duration += event.dur;
break;
}
if (event.name === 'MajorGC' || event.name === 'MinorGC') {
if (typeof event.args?.usedHeapSizeAfter === 'number' && typeof event.args.usedHeapSizeBefore === 'number') {
garbage += (event.args.usedHeapSizeBefore - event.args.usedHeapSizeAfter);
}
}
}
return { minorGCs, majorGCs, used, garbage, duration: Math.round(duration / 1000) };