mirror of
https://github.com/Microsoft/vscode
synced 2024-10-12 22:37:41 +00:00
Read the setting key for "Edit in settings.json" button Fix #106975
This commit is contained in:
parent
252bef02ce
commit
366f97bad4
|
@ -857,6 +857,8 @@ export class SettingNewExtensionsRenderer implements ITreeRenderer<SettingsTreeN
|
||||||
}
|
}
|
||||||
|
|
||||||
export class SettingComplexRenderer extends AbstractSettingRenderer implements ITreeRenderer<SettingsTreeSettingElement, never, ISettingComplexItemTemplate> {
|
export class SettingComplexRenderer extends AbstractSettingRenderer implements ITreeRenderer<SettingsTreeSettingElement, never, ISettingComplexItemTemplate> {
|
||||||
|
private static readonly EDIT_IN_JSON_LABEL = localize('editInSettingsJson', "Edit in settings.json");
|
||||||
|
|
||||||
templateId = SETTINGS_COMPLEX_TEMPLATE_ID;
|
templateId = SETTINGS_COMPLEX_TEMPLATE_ID;
|
||||||
|
|
||||||
renderTemplate(container: HTMLElement): ISettingComplexItemTemplate {
|
renderTemplate(container: HTMLElement): ISettingComplexItemTemplate {
|
||||||
|
@ -865,7 +867,7 @@ export class SettingComplexRenderer extends AbstractSettingRenderer implements I
|
||||||
const openSettingsButton = new Button(common.controlElement, { title: true, buttonBackground: undefined, buttonHoverBackground: undefined });
|
const openSettingsButton = new Button(common.controlElement, { title: true, buttonBackground: undefined, buttonHoverBackground: undefined });
|
||||||
common.toDispose.add(openSettingsButton);
|
common.toDispose.add(openSettingsButton);
|
||||||
common.toDispose.add(openSettingsButton.onDidClick(() => template.onChange!()));
|
common.toDispose.add(openSettingsButton.onDidClick(() => template.onChange!()));
|
||||||
openSettingsButton.label = localize('editInSettingsJson', "Edit in settings.json");
|
openSettingsButton.label = SettingComplexRenderer.EDIT_IN_JSON_LABEL;
|
||||||
openSettingsButton.element.classList.add('edit-in-settings-button');
|
openSettingsButton.element.classList.add('edit-in-settings-button');
|
||||||
|
|
||||||
common.toDispose.add(attachButtonStyler(openSettingsButton, this._themeService, {
|
common.toDispose.add(attachButtonStyler(openSettingsButton, this._themeService, {
|
||||||
|
@ -895,6 +897,8 @@ export class SettingComplexRenderer extends AbstractSettingRenderer implements I
|
||||||
protected renderValue(dataElement: SettingsTreeSettingElement, template: ISettingComplexItemTemplate, onChange: (value: string) => void): void {
|
protected renderValue(dataElement: SettingsTreeSettingElement, template: ISettingComplexItemTemplate, onChange: (value: string) => void): void {
|
||||||
template.onChange = () => this._onDidOpenSettings.fire(dataElement.setting.key);
|
template.onChange = () => this._onDidOpenSettings.fire(dataElement.setting.key);
|
||||||
this.renderValidations(dataElement, template);
|
this.renderValidations(dataElement, template);
|
||||||
|
|
||||||
|
template.button.element.setAttribute('aria-label', `${SettingComplexRenderer.EDIT_IN_JSON_LABEL}: ${dataElement.setting.key}`);
|
||||||
}
|
}
|
||||||
|
|
||||||
private renderValidations(dataElement: SettingsTreeSettingElement, template: ISettingComplexItemTemplate) {
|
private renderValidations(dataElement: SettingsTreeSettingElement, template: ISettingComplexItemTemplate) {
|
||||||
|
|
Loading…
Reference in a new issue