development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Stop the cursor from jumping when changing prefix in QuickAccess (#198821)" (#204638)

Browse source 
This reverts commit 3154b5f948.
This commit is contained in:
Tyler James Leonhardt 2024-02-07 10:06:45 -08:00 committed by GitHub
parent bc056d2978
commit 348e88dc00
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 2 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/vs/base/browser/ui/inputbox/inputBox.ts
View file

@ -305,18 +305,6 @@ export class InputBox extends Widget {
return this.input.selectionEnd === this.input.value.length && this.input.selectionStart === this.input.selectionEnd;
}
public getSelection(): IRange | null {
const selectionStart = this.input.selectionStart;
if (selectionStart === null) {
return null;
}
const selectionEnd = this.input.selectionEnd ?? selectionStart;
return {
start: selectionStart,
end: selectionEnd,
};
}
public enable(): void {
this.input.removeAttribute('disabled');
}

8
src/vs/platform/quickinput/browser/quickAccess.ts
View file

@ -92,9 +92,6 @@ export class QuickAccessController extends Disposable implements IQuickAccessCon
}
}
// Store the existing selection if there was one.
const visibleSelection = visibleQuickAccess?.picker?.valueSelection;
// Create a picker for the provider to use with the initial value
// and adjust the filtering to exclude the prefix from filtering
const disposables = new DisposableStore();
@ -151,11 +148,6 @@ export class QuickAccessController extends Disposable implements IQuickAccessCon
// on the onDidHide event.
picker.show();
// If the previous picker had a selection, we should set that in the new picker.
if (visibleSelection) {
picker.valueSelection = visibleSelection;
}
// Pick mode: return with promise
if (pick) {
return pickPromise?.p;

20
src/vs/platform/quickinput/browser/quickInput.ts
View file

@ -725,15 +725,7 @@ export class QuickPick<T extends IQuickPickItem> extends QuickInput implements I
return this.ui.keyMods;
}
get valueSelection() {
const selection = this.ui.inputBox.getSelection();
if (!selection) {
return undefined;
}
return [selection.start, selection.end];
}
set valueSelection(valueSelection: Readonly<[number, number]> | undefined) {
set valueSelection(valueSelection: Readonly<[number, number]>) {
this._valueSelection = valueSelection;
this.valueSelectionUpdated = true;
this.update();
@ -1162,15 +1154,7 @@ export class InputBox extends QuickInput implements IInputBox {
this.update();
}
get valueSelection() {
const selection = this.ui.inputBox.getSelection();
if (!selection) {
return undefined;
}
return [selection.start, selection.end];
}
set valueSelection(valueSelection: Readonly<[number, number]> | undefined) {
set valueSelection(valueSelection: Readonly<[number, number]>) {
this._valueSelection = valueSelection;
this.valueSelectionUpdated = true;
this.update();

4
src/vs/platform/quickinput/browser/quickInputBox.ts
View file

@ -59,10 +59,6 @@ export class QuickInputBox extends Disposable {
this.findInput.inputBox.select(range);
}
getSelection(): IRange | null {
return this.findInput.inputBox.getSelection();
}
isSelectionAtEnd(): boolean {
return this.findInput.inputBox.isSelectionAtEnd();
}