From 32c524af96680740df69599f05feec6a8a80154d Mon Sep 17 00:00:00 2001 From: Connor Peet Date: Fri, 22 Mar 2024 15:06:12 -0700 Subject: [PATCH] testing: properly apply group default default profiles (#208476) Fixes #206306 --- src/vs/workbench/api/browser/mainThreadTesting.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/api/browser/mainThreadTesting.ts b/src/vs/workbench/api/browser/mainThreadTesting.ts index c9976ce3727..a316bec0eb3 100644 --- a/src/vs/workbench/api/browser/mainThreadTesting.ts +++ b/src/vs/workbench/api/browser/mainThreadTesting.ts @@ -19,7 +19,7 @@ import { ITestProfileService } from 'vs/workbench/contrib/testing/common/testPro import { LiveTestResult } from 'vs/workbench/contrib/testing/common/testResult'; import { ITestResultService } from 'vs/workbench/contrib/testing/common/testResultService'; import { IMainThreadTestController, ITestRootProvider, ITestService } from 'vs/workbench/contrib/testing/common/testService'; -import { CoverageDetails, ExtensionRunTestsRequest, IFileCoverage, ITestItem, ITestMessage, ITestRunProfile, ITestRunTask, ResolvedTestRunRequest, TestResultState, TestsDiffOp } from 'vs/workbench/contrib/testing/common/testTypes'; +import { CoverageDetails, ExtensionRunTestsRequest, IFileCoverage, ITestItem, ITestMessage, ITestRunProfile, ITestRunTask, ResolvedTestRunRequest, TestResultState, TestRunProfileBitset, TestsDiffOp } from 'vs/workbench/contrib/testing/common/testTypes'; import { IExtHostContext, extHostNamedCustomer } from 'vs/workbench/services/extensions/common/extHostCustomers'; import { ExtHostContext, ExtHostTestingShape, ILocationDto, ITestControllerPatch, MainContext, MainThreadTestingShape } from '../common/extHost.protocol'; @@ -50,8 +50,11 @@ export class MainThreadTesting extends Disposable implements MainThreadTestingSh this._register(Event.debounce(testProfiles.onDidChange, (_last, e) => e)(() => { const obj: Record = {}; - for (const { controller, profiles } of this.testProfiles.all()) { - obj[controller.id] = profiles.filter(p => p.isDefault).map(p => p.profileId); + for (const group of [TestRunProfileBitset.Run, TestRunProfileBitset.Debug, TestRunProfileBitset.Coverage]) { + for (const profile of this.testProfiles.getGroupDefaultProfiles(group)) { + obj[profile.controllerId] ??= []; + obj[profile.controllerId].push(profile.profileId); + } } this.proxy.$setDefaultRunProfiles(obj);