development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

debug: log progress in NamedPipeDebugAdapter tests (#170713)

Browse source 
This test has timed out rarely, but several times in CI. I have tried to review the code and hit the failure locally, but without success. This PR adds a progress log that might contain a hint....
This commit is contained in:
Connor Peet 2023-01-06 11:28:01 -08:00 committed by GitHub
parent 409b1d8423
commit 32bb67bc16
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/vs/workbench/contrib/debug/test/node/streamDebugAdapter.test.ts
View file

@ -46,15 +46,23 @@ function serverConnection(socket: net.Socket) {
suite('Debug - StreamDebugAdapter', () => { suite('Debug - StreamDebugAdapter', () => {
test(`StreamDebugAdapter (NamedPipeDebugAdapter) can initialize a connection`, async () => { test(`StreamDebugAdapter (NamedPipeDebugAdapter) can initialize a connection`, async () => {
// todo@connor4312: debug test failure that seems to only happen in CI.
// Even running this test on a loop on my machine for an hour doesn't hit failures :(
const progress: string[] = [];
const timeout = setTimeout(() => {
console.log('NamedPipeDebugAdapter test might fail. Progress:', progress.join(','));
}, 1000); // should usually finish is <10ms
const pipeName = crypto.randomBytes(10).toString('hex'); const pipeName = crypto.randomBytes(10).toString('hex');
const pipePath = platform.isWindows ? join('\\\\.\\pipe\\', pipeName) : join(tmpdir(), pipeName); const pipePath = platform.isWindows ? join('\\\\.\\pipe\\', pipeName) : join(tmpdir(), pipeName);
progress.push(`listen on ${pipePath}`);
const server = await new Promise<net.Server>((resolve, reject) => { const server = await new Promise<net.Server>((resolve, reject) => {
const server = net.createServer(serverConnection); const server = net.createServer(serverConnection);
server.once('listening', () => resolve(server)); server.once('listening', () => resolve(server));
server.once('error', reject); server.once('error', reject);
server.listen(pipePath); server.listen(pipePath);
}); });
progress.push('server up');
const debugAdapter = new NamedPipeDebugAdapter({ const debugAdapter = new NamedPipeDebugAdapter({
type: 'pipeServer', type: 'pipeServer',
@ -62,12 +70,16 @@ suite('Debug - StreamDebugAdapter', () => {
}); });
try { try {
await debugAdapter.startSession(); await debugAdapter.startSession();
progress.push('started session');
const response: DebugProtocol.Response = await sendInitializeRequest(debugAdapter); const response: DebugProtocol.Response = await sendInitializeRequest(debugAdapter);
progress.push('got response');
assert.strictEqual(response.command, 'initialize'); assert.strictEqual(response.command, 'initialize');
assert.strictEqual(response.request_seq, 1); assert.strictEqual(response.request_seq, 1);
assert.strictEqual(response.success, true, response.message); assert.strictEqual(response.success, true, response.message);
} finally { } finally {
await debugAdapter.stopSession(); await debugAdapter.stopSession();
progress.push('stopped session');
clearTimeout(timeout);
server.close(); server.close();
debugAdapter.dispose(); debugAdapter.dispose();
} }