development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-02 09:18:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

ts server crash open issue reporter (#207526)

Browse source 
minor open reporter changes
This commit is contained in:
Justin Chen 2024-03-13 15:58:33 -07:00 committed by GitHub
parent 9962e85fc9
commit 315ae79d96
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
extensions/typescript-language-features/src/typescriptServiceClient.ts
View file

@ -653,7 +653,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType
if (!this._isPromptingAfterCrash) {
if (this.pluginManager.plugins.length) {
prompt = vscode.window.showWarningMessage<vscode.MessageItem>(
vscode.l10n.t("The JS/TS language service crashed.\nThis may be caused by a plugin contributed by one of these extensions: {0}.\nPlease try disabling these extensions before filing an issue against VS Code.", pluginExtensionList));
vscode.l10n.t("The JS/TS language service crashed.\nThis may be caused by a plugin contributed by one of these extensions: {0}.\nPlease try disabling these extensions before filing an issue against VS Code.", pluginExtensionList), reportIssueItem);
} else {
prompt = vscode.window.showWarningMessage(
vscode.l10n.t("The JS/TS language service crashed."),
@ -1039,7 +1039,7 @@ function getReportIssueArgsForError(
error: TypeScriptServerError,
tsServerLog: TsServerLog | undefined,
globalPlugins: readonly TypeScriptServerPlugin[],
): { extensionId: string; issueTitle: string; issueBody: string } | undefined {
): { extensionId: string; issueTitle: string; issueBody: string; issueSource: string; issueData: string } | undefined {
if (!error.serverStack || !error.serverMessage) {
return undefined;
}
@ -1089,19 +1089,20 @@ The log file may contain personal data, including full paths and source code fro
After enabling this setting, future crash reports will include the server log.`);
}
sections.push(`**TS Server Error Stack**
const serverErrorStack = `**TS Server Error Stack**
Server: \`${error.serverId}\`
\`\`\`
${error.serverStack}
\`\`\``);
\`\`\``;
return {
extensionId: 'vscode.typescript-language-features',
issueTitle: `TS Server fatal error: ${error.serverMessage}`,
issueBody: sections.join('\n\n')
issueSource: 'vscode',
issueBody: sections.join('\n\n'),
issueData: serverErrorStack,
};
}