development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-01 08:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

add failing/skipped test for https://github.com/microsoft/vscode/issues/191070 (#200125)

Browse source 
* fix --dev option of unit tests fyi @joaomoreno

* fix timing issue when getting line, add failing/skipped test for https://github.com/microsoft/vscode/issues/191070
This commit is contained in:
Johannes Rieken 2023-12-06 12:16:49 +01:00 committed by GitHub
parent 5455d20ce1
commit 3056f52f92
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 37 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/vs/workbench/contrib/snippets/browser/snippetCompletionProvider.ts
View file

@ -85,13 +85,13 @@ export class SnippetCompletionProvider implements CompletionItemProvider {
async provideCompletionItems(model: ITextModel, position: Position, context: CompletionContext): Promise<CompletionList> {
const sw = new StopWatch();
const lineContentLow = model.getLineContent(position.lineNumber).toLowerCase();
const wordUntil = model.getWordUntilPosition(position).word.toLowerCase();
const languageId = this._getLanguageIdAtPosition(model, position);
const languageConfig = this._languageConfigurationService.getLanguageConfiguration(languageId);
const snippets = new Set(await this._snippets.getSnippets(languageId));
const lineContentLow = model.getLineContent(position.lineNumber).toLowerCase();
const wordUntil = model.getWordUntilPosition(position).word.toLowerCase();
const suggestions: SnippetCompletion[] = [];
const columnOffset = position.column - 1;

32
src/vs/workbench/contrib/snippets/test/browser/snippetsService.test.ts
View file

@ -819,4 +819,36 @@ suite('SnippetsService', function () {
const first = result.suggestions[0];
assert.strictEqual((<CompletionItemRanges>first.range).insert.startColumn, 5);
});
test.skip('Autocomplete suggests based on the last letter of a word and it depends on the typing speed #191070', async function () {
snippetService = new SimpleSnippetService([
new Snippet(false, ['fooLang'], '/whiletrue', '/whiletrue', '', 'one', '', SnippetSource.User, generateUuid()),
new Snippet(false, ['fooLang'], '/sc not expanding', '/sc not expanding', '', 'two', '', SnippetSource.User, generateUuid()),
]);
const provider = new SnippetCompletionProvider(languageService, snippetService, disposables.add(new TestLanguageConfigurationService()));
const model = disposables.add(instantiateTextModel(instantiationService, '', 'fooLang'));
{ // PREFIX: w
model.setValue('w');
const result1 = await provider.provideCompletionItems(
model,
new Position(1, 2),
{ triggerKind: CompletionTriggerKind.Invoke }
);
assert.strictEqual(result1.suggestions.length, 1);
assert.strictEqual(result1.suggestions[0].insertText, 'one');
}
{ // PREFIX: where
model.setValue('where');
const result2 = await provider.provideCompletionItems(
model,
new Position(1, 6),
{ triggerKind: CompletionTriggerKind.Invoke }
);
assert.strictEqual(result2.suggestions.length, 1);
assert.strictEqual(result2.suggestions[1].insertText, 'one'); // /whiletrue matches where (WHilEtRuE)
}
});
});

4
test/unit/electron/index.js
View file

@ -43,8 +43,8 @@ const minimist = require('minimist');
* }}
*/
const args = minimist(process.argv.slice(2), {
string: ['grep', 'run', 'runGlob', 'dev', 'reporter', 'reporter-options', 'wait-server', 'timeout', 'crash-reporter-directory', 'tfs'],
boolean: ['build', 'coverage', 'help'],
string: ['grep', 'run', 'runGlob', 'reporter', 'reporter-options', 'wait-server', 'timeout', 'crash-reporter-directory', 'tfs'],
boolean: ['build', 'coverage', 'help', 'dev'],
alias: {
'grep': ['g', 'f'],
'runGlob': ['glob', 'runGrep'],