From 2eb4b1aebdcc9d1c1c19d9bcc6e8deb0292fdb13 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Tue, 16 Jul 2019 14:09:12 -0700 Subject: [PATCH] Improve types --- test/smoke/src/vscode/puppeteer-driver.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/test/smoke/src/vscode/puppeteer-driver.ts b/test/smoke/src/vscode/puppeteer-driver.ts index 927af49964b..f864aede94b 100644 --- a/test/smoke/src/vscode/puppeteer-driver.ts +++ b/test/smoke/src/vscode/puppeteer-driver.ts @@ -3,9 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ -const puppeteer = require('puppeteer'); - -// export function connect(outPath: string, handle: string): Promise<{ client: IDisposable, driver: IDriver }> +import * as puppeteer from 'puppeteer'; const width = 1200; const height = 800; @@ -16,7 +14,7 @@ const vscodeToPuppeteerKey = { enter: 'Enter' }; -function buildDriver(browser, page) { +function buildDriver(browser: puppeteer.Browser, page: puppeteer.Page): IDriver { return { _serviceBrand: undefined, getWindowIds: () => { @@ -36,11 +34,10 @@ function buildDriver(browser, page) { keysDown.push(keys[i]); } while (keysDown.length > 0) { - await page.keyboard.up(keysDown.pop()); + await page.keyboard.up(keysDown.pop()!); } }, click: async (windowId, selector, xoffset, yoffset) => { - console.log('click'); const { x, y } = await page.evaluate(` (function() { function convertToPixels(element, value) {