development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move strict null checks from precomit to test

Browse source 
These checks are now taking a few seconds to run. This will continue to slow down as we null check more files. Moving them to the test scripts as pretest checks instead
This commit is contained in:
Matt Bierner 2018-10-10 18:35:03 -07:00
parent a2738f73e5
commit 2d4b7cb12e
3 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -15,7 +15,7 @@
"watch": "gulp watch --max_old_space_size=4095", "watch": "gulp watch --max_old_space_size=4095",
"watch-client": "gulp watch-client --max_old_space_size=4095", "watch-client": "gulp watch-client --max_old_space_size=4095",
"monaco-editor-test": "mocha --only-monaco-editor", "monaco-editor-test": "mocha --only-monaco-editor",
"precommit": "node build/gulpfile.hygiene.js && npm run strict-null-check", "precommit": "node build/gulpfile.hygiene.js",
"gulp": "gulp --max_old_space_size=4095", "gulp": "gulp --max_old_space_size=4095",
"7z": "7z", "7z": "7z",
"update-grammars": "node build/npm/update-all-grammars.js", "update-grammars": "node build/npm/update-all-grammars.js",

3
scripts/test.bat
View file

@ -15,6 +15,9 @@ set CODE=".build\electron\%NAMESHORT%"
node build\lib\electron.js node build\lib\electron.js
if %errorlevel% neq 0 node .\node_modules\gulp\bin\gulp.js electron if %errorlevel% neq 0 node .\node_modules\gulp\bin\gulp.js electron
:: Pretest
yarn strict-null-check
:: Run tests :: Run tests
%CODE% .\test\electron\index.js %* %CODE% .\test\electron\index.js %*

3
scripts/test.sh
View file

@ -28,6 +28,9 @@ test -d node_modules || yarn
# Get electron # Get electron
node build/lib/electron.js || ./node_modules/.bin/gulp electron node build/lib/electron.js || ./node_modules/.bin/gulp electron
# Pretest
yarn strict-null-check
# Unit Tests # Unit Tests
if [[ "$OSTYPE" == "darwin"* ]]; then if [[ "$OSTYPE" == "darwin"* ]]; then
cd $ROOT ; ulimit -n 4096 ; \ cd $ROOT ; ulimit -n 4096 ; \