Move strict null checks from precomit to test

These checks are now taking a few seconds to run. This will continue to slow down as we null check more files. Moving them to the test scripts as pretest checks instead

package.json

@@ -15,7 +15,7 @@
     "watch": "gulp watch --max_old_space_size=4095",
     "watch-client": "gulp watch-client --max_old_space_size=4095",
     "monaco-editor-test": "mocha --only-monaco-editor",
-    "precommit": "node build/gulpfile.hygiene.js && npm run strict-null-check",
+    "precommit": "node build/gulpfile.hygiene.js",
     "gulp": "gulp --max_old_space_size=4095",
     "7z": "7z",
     "update-grammars": "node build/npm/update-all-grammars.js",

scripts/test.bat

@@ -15,6 +15,9 @@ set CODE=".build\electron\%NAMESHORT%"
 node build\lib\electron.js
 if %errorlevel% neq 0 node .\node_modules\gulp\bin\gulp.js electron
 
+:: Pretest
+yarn strict-null-check
+
 :: Run tests
 %CODE% .\test\electron\index.js %*
 

scripts/test.sh

@@ -28,6 +28,9 @@ test -d node_modules || yarn
 # Get electron
 node build/lib/electron.js || ./node_modules/.bin/gulp electron
 
+# Pretest
+yarn strict-null-check
+
 # Unit Tests
 if [[ "$OSTYPE" == "darwin"* ]]; then
 	cd $ROOT ; ulimit -n 4096 ; \