mirror of
https://github.com/Microsoft/vscode
synced 2024-08-27 04:49:35 +00:00
Merge pull request #186522 from microsoft/merogge/fix-key
use new command ID for help menu aria label hint
This commit is contained in:
commit
2b5fad6158
|
@ -100,7 +100,7 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
|
|||
private _getAriaLabel(): string {
|
||||
const verbose = this.configurationService.getValue<boolean>(AccessibilityVerbositySettingId.Chat);
|
||||
if (verbose) {
|
||||
const kbLabel = this.keybindingService.lookupKeybinding('chat.action.accessibilityHelp')?.getLabel();
|
||||
const kbLabel = this.keybindingService.lookupKeybinding('editor.action.accessibilityHelp')?.getLabel();
|
||||
return kbLabel ? localize('actions.chat.accessibiltyHelp', "Chat Input, Type to ask questions or type / for topics, press enter to send out the request. Use {0} for Chat Accessibility Help.", kbLabel) : localize('chatInput.accessibilityHelpNoKb', "Chat Input, Type code here and press Enter to run. Use the Chat Accessibility Help command for more information.");
|
||||
}
|
||||
return localize('chatInput', "Chat Input");
|
||||
|
|
|
@ -336,7 +336,7 @@ export class InlineChatWidget {
|
|||
}
|
||||
let label = defaultAriaLabel;
|
||||
if (this._configurationService.getValue<boolean>(AccessibilityVerbositySettingId.InlineChat)) {
|
||||
const kbLabel = this._keybindingService.lookupKeybinding('inlineChat.accessibilityHelp')?.getLabel();
|
||||
const kbLabel = this._keybindingService.lookupKeybinding('editor.action.accessibilityHelp')?.getLabel();
|
||||
label = kbLabel ? localize('inlineChat.accessibilityHelp', "Inline Chat Input, Use {0} for Inline Chat Accessibility Help.", kbLabel) : localize('inlineChat.accessibilityHelpNoKb', "Inline Chat Input, Run the Inline Chat Accessibility Help command for more information.");
|
||||
}
|
||||
_inputEditorOptions.ariaLabel = label;
|
||||
|
|
|
@ -1879,7 +1879,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
|
|||
if (!screenReaderOptimized) {
|
||||
labelParts.push(nls.localize('terminalScreenReaderMode', "Run the command: Toggle Screen Reader Accessibility Mode for an optimized screen reader experience"));
|
||||
}
|
||||
const accessibilityHelpKeybinding = this._keybindingService.lookupKeybinding(TerminalCommandId.ShowTerminalAccessibilityHelp)?.getLabel();
|
||||
const accessibilityHelpKeybinding = this._keybindingService.lookupKeybinding('editor.action.accessibilityHelp')?.getLabel();
|
||||
if (this._configurationService.getValue(AccessibilityVerbositySettingId.Terminal) && accessibilityHelpKeybinding) {
|
||||
labelParts.push(nls.localize('terminalHelpAriaLabel', "Use {0} for terminal accessibility help", accessibilityHelpKeybinding));
|
||||
}
|
||||
|
|
|
@ -488,7 +488,6 @@ export const enum TerminalCommandId {
|
|||
MoveToTerminalPanel = 'workbench.action.terminal.moveToTerminalPanel',
|
||||
SetDimensions = 'workbench.action.terminal.setDimensions',
|
||||
ClearPreviousSessionHistory = 'workbench.action.terminal.clearPreviousSessionHistory',
|
||||
ShowTerminalAccessibilityHelp = 'workbench.action.terminal.showAccessibilityHelp',
|
||||
SelectPrevSuggestion = 'workbench.action.terminal.selectPrevSuggestion',
|
||||
SelectPrevPageSuggestion = 'workbench.action.terminal.selectPrevPageSuggestion',
|
||||
SelectNextSuggestion = 'workbench.action.terminal.selectNextSuggestion',
|
||||
|
@ -569,8 +568,8 @@ export const DEFAULT_COMMANDS_TO_SKIP_SHELL: string[] = [
|
|||
TerminalCommandId.SelectNextPageSuggestion,
|
||||
TerminalCommandId.AcceptSelectedSuggestion,
|
||||
TerminalCommandId.HideSuggestWidget,
|
||||
TerminalCommandId.ShowTerminalAccessibilityHelp,
|
||||
TerminalCommandId.FocusHover,
|
||||
'editor.action.accessibilityHelp',
|
||||
'editor.action.toggleTabFocusMode',
|
||||
'notifications.hideList',
|
||||
'notifications.hideToasts',
|
||||
|
|
Loading…
Reference in a new issue