From 29ddbd371efc6fa4b231bfc760d328907497453e Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed, 8 Nov 2023 09:39:40 -0800 Subject: [PATCH] Simplify polling --- .../src/areas/terminal/terminal-stickyScroll.test.ts | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/test/smoke/src/areas/terminal/terminal-stickyScroll.test.ts b/test/smoke/src/areas/terminal/terminal-stickyScroll.test.ts index e349dac11c4..e7c7f7a068d 100644 --- a/test/smoke/src/areas/terminal/terminal-stickyScroll.test.ts +++ b/test/smoke/src/areas/terminal/terminal-stickyScroll.test.ts @@ -48,13 +48,11 @@ export function setup() { await terminal.runCommandWithValue(TerminalCommandIdWithValue.WriteDataToTerminal, data); const element = await app.code.getElement('.terminal-sticky-scroll .xterm-rows'); if (element && element.textContent.indexOf(`Prompt> ${command}`) >= 0) { - break; - } - if (i === 10) { - throw new Error(`Polling failed for command ${command}, exitcode ${exitCode}, text content ${element?.textContent}`); + return; } await timeout(1000); } + throw new Error(`Polling failed for command ${command}, exitcode ${exitCode}, text content ${element?.textContent}`); } // Write prompt, fill viewport, finish command, print new prompt, verify sticky scroll @@ -62,9 +60,6 @@ export function setup() { // And again with a failed command await pollForCommandAndOutput('sticky scroll 2', 1); - - // And again with a failed command - await pollForCommandAndOutput('sticky scroll 3', 0); }); }); }