development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 13:46:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Unit test failure: TextFileEditorModel save() and isDirty() (fix #161886) (#161891)

Browse source
This commit is contained in:
Benjamin Pasero 2022-09-27 00:25:39 -07:00 committed by GitHub
parent 36b1398cfb
commit 26ef29d3ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/vs/workbench/services/textfile/test/browser/textFileEditorModel.test.ts
View file

@ -21,6 +21,7 @@ import { DisposableStore } from 'vs/base/common/lifecycle';
import { SaveReason, SaveSourceRegistry } from 'vs/workbench/common/editor';
import { isEqual } from 'vs/base/common/resources';
import { UTF16be } from 'vs/workbench/services/textfile/common/encoding';
import { isWeb } from 'vs/base/common/platform';
suite('Files - TextFileEditorModel', () => {
@ -655,8 +656,18 @@ suite('Files - TextFileEditorModel', () => {
await accessor.textFileService.save(toResource.call(this, '/path/index_async2.txt'));
assert.ok(!accessor.textFileService.isDirty(toResource.call(this, '/path/index_async.txt')));
assert.ok(!accessor.textFileService.isDirty(toResource.call(this, '/path/index_async2.txt')));
assert.ok(assertIsDefined(getLastResolvedFileStat(model1)).mtime > m1Mtime);
assert.ok(assertIsDefined(getLastResolvedFileStat(model2)).mtime > m2Mtime);
if (isWeb) {
// web tests does not ensure timeouts are respected at all, so we cannot
// really assert the mtime to be different, only that it is equal or greater.
// https://github.com/microsoft/vscode/issues/161886
assert.ok(assertIsDefined(getLastResolvedFileStat(model1)).mtime >= m1Mtime);
assert.ok(assertIsDefined(getLastResolvedFileStat(model2)).mtime >= m2Mtime);
} else {
// on desktop we want to assert this condition more strictly though
assert.ok(assertIsDefined(getLastResolvedFileStat(model1)).mtime > m1Mtime);
assert.ok(assertIsDefined(getLastResolvedFileStat(model2)).mtime > m2Mtime);
}
model1.dispose();
model2.dispose();