development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

dispose tree and model in problems view

Browse source
This commit is contained in:
Sandeep Somavarapu 2016-06-15 10:55:07 +02:00
parent 07926e59b8
commit 26b0272bf3
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/vs/workbench/parts/markers/browser/markersPanel.ts
View file

@ -67,7 +67,6 @@ export class MarkersPanel extends Panel {
@ITelemetryService telemetryService: ITelemetryService
) {
super(Constants.MARKERS_PANEL_ID, telemetryService);
this.markersModel = new MarkersModel();
this.toDispose = [];
this.delayedRefresh = new Delayer<void>(1000);
this.autoExpanded = new Set.ArraySet<string>();
@ -75,6 +74,8 @@ export class MarkersPanel extends Panel {
public create(parent: builder.Builder): TPromise<void> {
super.create(parent);
this.markersModel = new MarkersModel();
dom.addClass(parent.getHTMLElement(), 'markers-panel');
const conf = this.configurationService.getConfiguration<IProblemsConfiguration>();
@ -307,6 +308,8 @@ export class MarkersPanel extends Panel {
public dispose(): void {
this.delayedRefresh.cancel();
this.toDispose = lifecycle.dispose(this.toDispose);
this.tree.dispose();
this.markersModel.dispose();
super.dispose();
}
}

6
src/vs/workbench/parts/markers/common/markersModel.ts
View file

@ -259,6 +259,12 @@ export class MarkersModel {
return {errors: errors, warnings: warnings, infos: infos, unknwons: unknowns};
}
public dispose() : void {
this.markersByResource.clear();
this._filteredResources= [];
this._nonFilteredResources= [];
}
public getTitle(markerStatistics: MarkerStatistics):string {
let title= MarkersModel.getStatisticsLabel(markerStatistics);
return title ? title : Messages.MARKERS_PANEL_TITLE_NO_PROBLEMS;