development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 13:29:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix leaked interval in dialog

Browse source
This commit is contained in:
Daniel Imms 2019-04-24 08:17:01 -07:00
parent 21be97cbfc
commit 259658eb28
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/vs/base/browser/ui/dialog/dialog.ts
View file

@ -40,7 +40,7 @@ export class Dialog extends Disposable {
private buttonGroup: ButtonGroup | undefined;
private styles: IDialogStyles | undefined;
private focusToReturn: HTMLElement | undefined;
private iconRotatingInternal: any | undefined;
private iconRotatingInternal: NodeJS.Timer | undefined;
constructor(private container: HTMLElement, private message: string, private buttons: string[], private options: IDialogOptions) {
super();
@ -169,7 +169,7 @@ export class Dialog extends Disposable {
this.iconElement.style.transform = `rotate(${deg}deg)`;
deg += 45; // 360 / 8
} else {
this.iconRotatingInternal = undefined;
this.stopAnimation();
}
}, 125 /** 1000 / 8 */);
break;
@ -199,6 +199,13 @@ export class Dialog extends Disposable {
});
}
private stopAnimation() {
if (this.iconRotatingInternal) {
clearInterval(this.iconRotatingInternal);
this.iconRotatingInternal = undefined;
}
}
private applyStyles() {
if (this.styles) {
const style = this.styles;
@ -233,9 +240,7 @@ export class Dialog extends Disposable {
this.modal = undefined;
}
if (this.iconRotatingInternal) {
this.iconRotatingInternal = undefined;
}
this.stopAnimation();
if (this.focusToReturn && isAncestor(this.focusToReturn, document.body)) {
this.focusToReturn.focus();