development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 05:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

💄 cleanup abstract update service

Browse source
This commit is contained in:
Joao Moreno 2019-01-04 16:47:38 +01:00
parent 910284fc29
commit 258aac466a
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/vs/platform/update/electron-main/abstractUpdateService.ts
View file

@ -56,8 +56,8 @@ export abstract class AbstractUpdateService implements IUpdateService {
return;
}
const quality = this.getProductQuality();
const channel = this.configurationService.getValue<string>('update.channel');
const updateChannel = this.configurationService.getValue<string>('update.channel');
const quality = this.getProductQuality(updateChannel);
if (!quality) {
this.logService.info('update#ctor - updates are disabled by user preference');
@ -72,7 +72,7 @@ export abstract class AbstractUpdateService implements IUpdateService {
this.setState(State.Idle(this.getUpdateType()));
if (channel === 'manual') {
if (updateChannel === 'manual') {
this.logService.info('update#ctor - manual checks only; automatic updates are disabled by user preference');
return;
}
@ -81,9 +81,8 @@ export abstract class AbstractUpdateService implements IUpdateService {
this.scheduleCheckForUpdates(30 * 1000).then(undefined, err => this.logService.error(err));
}
private getProductQuality(): string | undefined {
const quality = this.configurationService.getValue<string>('update.channel');
return quality === 'none' ? undefined : product.quality;
private getProductQuality(updateChannel: string): string | undefined {
return updateChannel === 'none' ? undefined : product.quality;
}
private scheduleCheckForUpdates(delay = 60 * 60 * 1000): Promise<void> {