development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-28 23:42:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not await clipboard image data when not supported (#229835)

Browse source 
Don't await clipboard image data when not supported
This commit is contained in:
Benjamin Christopher Simmonds 2024-09-26 16:58:50 +02:00 committed by GitHub
parent 178c125fe2
commit 2544a7b03f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/vs/workbench/contrib/chat/browser/actions/chatContextActions.ts
View file

@ -334,8 +334,6 @@ class AttachContextAction extends Action2 {
return;
}
const imageData = await clipboardService.readImage();
const usedAgent = widget.parsedInput.parts.find(p => p instanceof ChatRequestAgentPart);
const slowSupported = usedAgent ? usedAgent.agent.metadata.supportsSlowVariables : true;
const quickPickItems: (IChatContextQuickPickItem | QuickPickItem)[] = [];
@ -351,13 +349,16 @@ class AttachContextAction extends Action2 {
}
}
if (isImage(imageData) && configurationService.getValue<boolean>('chat.experimental.imageAttachments')) {
quickPickItems.push({
id: await imageToHash(imageData),
kind: 'image',
label: localize('imageFromClipboard', 'Image from Clipboard'),
iconClass: ThemeIcon.asClassName(Codicon.fileMedia),
});
if (configurationService.getValue<boolean>('chat.experimental.imageAttachments')) {
const imageData = await clipboardService.readImage();
if (isImage(imageData)) {
quickPickItems.push({
id: await imageToHash(imageData),
kind: 'image',
label: localize('imageFromClipboard', 'Image from Clipboard'),
iconClass: ThemeIcon.asClassName(Codicon.fileMedia),
});
}
}
if (widget.viewModel?.sessionId) {