SCM - Add document property to expose the text document (#171504)

This commit is contained in:
Ladislau Szomoru 2023-04-14 13:55:14 +02:00 committed by GitHub
parent 316995c8b6
commit 218b8bd8da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 52 additions and 21 deletions

View file

@ -27,6 +27,7 @@
"resolvers", "resolvers",
"scmActionButton", "scmActionButton",
"scmSelectedProvider", "scmSelectedProvider",
"scmTextDocument",
"scmValidation", "scmValidation",
"taskPresentationGroup", "taskPresentationGroup",
"terminalDataWriteEvent", "terminalDataWriteEvent",

View file

@ -117,6 +117,7 @@ class MainThreadSCMProvider implements ISCMProvider, QuickDiffProvider {
get handle(): number { return this._handle; } get handle(): number { return this._handle; }
get label(): string { return this._label; } get label(): string { return this._label; }
get rootUri(): URI | undefined { return this._rootUri; } get rootUri(): URI | undefined { return this._rootUri; }
get inputBoxDocumentUri(): URI { return this._inputBoxDocumentUri; }
get contextValue(): string { return this._contextValue; } get contextValue(): string { return this._contextValue; }
get commitTemplate(): string { return this.features.commitTemplate || ''; } get commitTemplate(): string { return this.features.commitTemplate || ''; }
@ -143,6 +144,7 @@ class MainThreadSCMProvider implements ISCMProvider, QuickDiffProvider {
private readonly _contextValue: string, private readonly _contextValue: string,
private readonly _label: string, private readonly _label: string,
private readonly _rootUri: URI | undefined, private readonly _rootUri: URI | undefined,
private readonly _inputBoxDocumentUri: URI,
private readonly _quickDiffService: IQuickDiffService private readonly _quickDiffService: IQuickDiffService
) { } ) { }
@ -317,8 +319,8 @@ export class MainThreadSCM implements MainThreadSCMShape {
this._disposables.dispose(); this._disposables.dispose();
} }
$registerSourceControl(handle: number, id: string, label: string, rootUri: UriComponents | undefined): void { $registerSourceControl(handle: number, id: string, label: string, rootUri: UriComponents | undefined, inputBoxDocumentUri: UriComponents): void {
const provider = new MainThreadSCMProvider(this._proxy, handle, id, label, rootUri ? URI.revive(rootUri) : undefined, this.quickDiffService); const provider = new MainThreadSCMProvider(this._proxy, handle, id, label, rootUri ? URI.revive(rootUri) : undefined, URI.revive(inputBoxDocumentUri), this.quickDiffService);
const repository = this.scmService.registerSCMProvider(provider); const repository = this.scmService.registerSCMProvider(provider);
this._repositories.set(handle, repository); this._repositories.set(handle, repository);

View file

@ -180,7 +180,7 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
const extHostFileSystem = rpcProtocol.set(ExtHostContext.ExtHostFileSystem, new ExtHostFileSystem(rpcProtocol, extHostLanguageFeatures)); const extHostFileSystem = rpcProtocol.set(ExtHostContext.ExtHostFileSystem, new ExtHostFileSystem(rpcProtocol, extHostLanguageFeatures));
const extHostFileSystemEvent = rpcProtocol.set(ExtHostContext.ExtHostFileSystemEventService, new ExtHostFileSystemEventService(rpcProtocol, extHostLogService, extHostDocumentsAndEditors)); const extHostFileSystemEvent = rpcProtocol.set(ExtHostContext.ExtHostFileSystemEventService, new ExtHostFileSystemEventService(rpcProtocol, extHostLogService, extHostDocumentsAndEditors));
const extHostQuickOpen = rpcProtocol.set(ExtHostContext.ExtHostQuickOpen, createExtHostQuickOpen(rpcProtocol, extHostWorkspace, extHostCommands)); const extHostQuickOpen = rpcProtocol.set(ExtHostContext.ExtHostQuickOpen, createExtHostQuickOpen(rpcProtocol, extHostWorkspace, extHostCommands));
const extHostSCM = rpcProtocol.set(ExtHostContext.ExtHostSCM, new ExtHostSCM(rpcProtocol, extHostCommands, extHostLogService)); const extHostSCM = rpcProtocol.set(ExtHostContext.ExtHostSCM, new ExtHostSCM(rpcProtocol, extHostCommands, extHostDocuments, extHostLogService));
const extHostQuickDiff = rpcProtocol.set(ExtHostContext.ExtHostQuickDiff, new ExtHostQuickDiff(rpcProtocol, uriTransformer)); const extHostQuickDiff = rpcProtocol.set(ExtHostContext.ExtHostQuickDiff, new ExtHostQuickDiff(rpcProtocol, uriTransformer));
const extHostComment = rpcProtocol.set(ExtHostContext.ExtHostComments, createExtHostComments(rpcProtocol, extHostCommands, extHostDocuments)); const extHostComment = rpcProtocol.set(ExtHostContext.ExtHostComments, createExtHostComments(rpcProtocol, extHostCommands, extHostDocuments));
const extHostProgress = rpcProtocol.set(ExtHostContext.ExtHostProgress, new ExtHostProgress(rpcProtocol.getProxy(MainContext.MainThreadProgress))); const extHostProgress = rpcProtocol.set(ExtHostContext.ExtHostProgress, new ExtHostProgress(rpcProtocol.getProxy(MainContext.MainThreadProgress)));

View file

@ -1283,7 +1283,7 @@ export type SCMRawResourceSplices = [
]; ];
export interface MainThreadSCMShape extends IDisposable { export interface MainThreadSCMShape extends IDisposable {
$registerSourceControl(handle: number, id: string, label: string, rootUri: UriComponents | undefined): void; $registerSourceControl(handle: number, id: string, label: string, rootUri: UriComponents | undefined, inputBoxDocumentUri: UriComponents): void;
$updateSourceControl(handle: number, features: SCMProviderFeatures): void; $updateSourceControl(handle: number, features: SCMProviderFeatures): void;
$unregisterSourceControl(handle: number): void; $unregisterSourceControl(handle: number): void;

View file

@ -22,6 +22,8 @@ import { ThemeIcon } from 'vs/base/common/themables';
import { IMarkdownString } from 'vs/base/common/htmlContent'; import { IMarkdownString } from 'vs/base/common/htmlContent';
import { MarkdownString } from 'vs/workbench/api/common/extHostTypeConverters'; import { MarkdownString } from 'vs/workbench/api/common/extHostTypeConverters';
import { checkProposedApiEnabled, isProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions'; import { checkProposedApiEnabled, isProposedApiEnabled } from 'vs/workbench/services/extensions/common/extensions';
import { ExtHostDocuments } from 'vs/workbench/api/common/extHostDocuments';
import { Schemas } from 'vs/base/common/network';
type ProviderHandle = number; type ProviderHandle = number;
type GroupHandle = number; type GroupHandle = number;
@ -200,6 +202,7 @@ export interface IValidateInput {
export class ExtHostSCMInputBox implements vscode.SourceControlInputBox { export class ExtHostSCMInputBox implements vscode.SourceControlInputBox {
#proxy: MainThreadSCMShape; #proxy: MainThreadSCMShape;
#extHostDocuments: ExtHostDocuments;
private _value: string = ''; private _value: string = '';
@ -283,7 +286,14 @@ export class ExtHostSCMInputBox implements vscode.SourceControlInputBox {
this.#proxy.$setInputBoxVisibility(this._sourceControlHandle, visible); this.#proxy.$setInputBoxVisibility(this._sourceControlHandle, visible);
} }
constructor(private _extension: IExtensionDescription, proxy: MainThreadSCMShape, private _sourceControlHandle: number) { get document(): vscode.TextDocument {
checkProposedApiEnabled(this._extension, 'scmTextDocument');
return this.#extHostDocuments.getDocument(this._documentUri);
}
constructor(private _extension: IExtensionDescription, _extHostDocuments: ExtHostDocuments, proxy: MainThreadSCMShape, private _sourceControlHandle: number, private _documentUri: URI) {
this.#extHostDocuments = _extHostDocuments;
this.#proxy = proxy; this.#proxy = proxy;
} }
@ -584,6 +594,7 @@ class ExtHostSourceControl implements vscode.SourceControl {
constructor( constructor(
private readonly _extension: IExtensionDescription, private readonly _extension: IExtensionDescription,
_extHostDocuments: ExtHostDocuments,
proxy: MainThreadSCMShape, proxy: MainThreadSCMShape,
private _commands: ExtHostCommands, private _commands: ExtHostCommands,
private _id: string, private _id: string,
@ -592,8 +603,14 @@ class ExtHostSourceControl implements vscode.SourceControl {
) { ) {
this.#proxy = proxy; this.#proxy = proxy;
this._inputBox = new ExtHostSCMInputBox(_extension, this.#proxy, this.handle); const inputBoxDocumentUri = URI.from({
this.#proxy.$registerSourceControl(this.handle, _id, _label, _rootUri); scheme: Schemas.vscodeSourceControl,
path: `${_id}/scm${this.handle}/input`,
query: _rootUri ? `rootUri=${encodeURIComponent(_rootUri.toString())}` : undefined
});
this._inputBox = new ExtHostSCMInputBox(_extension, _extHostDocuments, this.#proxy, this.handle, inputBoxDocumentUri);
this.#proxy.$registerSourceControl(this.handle, _id, _label, _rootUri, inputBoxDocumentUri);
} }
private createdResourceGroups = new Map<ExtHostSourceControlResourceGroup, IDisposable>(); private createdResourceGroups = new Map<ExtHostSourceControlResourceGroup, IDisposable>();
@ -699,6 +716,7 @@ export class ExtHostSCM implements ExtHostSCMShape {
constructor( constructor(
mainContext: IMainContext, mainContext: IMainContext,
private _commands: ExtHostCommands, private _commands: ExtHostCommands,
private _extHostDocuments: ExtHostDocuments,
@ILogService private readonly logService: ILogService @ILogService private readonly logService: ILogService
) { ) {
this._proxy = mainContext.getProxy(MainContext.MainThreadSCM); this._proxy = mainContext.getProxy(MainContext.MainThreadSCM);
@ -757,7 +775,7 @@ export class ExtHostSCM implements ExtHostSCMShape {
}); });
const handle = ExtHostSCM._handlePool++; const handle = ExtHostSCM._handlePool++;
const sourceControl = new ExtHostSourceControl(extension, this._proxy, this._commands, id, label, rootUri); const sourceControl = new ExtHostSourceControl(extension, this._extHostDocuments, this._proxy, this._commands, id, label, rootUri);
this._sourceControls.set(handle, sourceControl); this._sourceControls.set(handle, sourceControl);
const sourceControls = this._sourceControlsByExtension.get(extension.identifier) || []; const sourceControls = this._sourceControlsByExtension.get(extension.identifier) || [];

View file

@ -57,7 +57,6 @@ import * as platform from 'vs/base/common/platform';
import { compare, format } from 'vs/base/common/strings'; import { compare, format } from 'vs/base/common/strings';
import { SuggestController } from 'vs/editor/contrib/suggest/browser/suggestController'; import { SuggestController } from 'vs/editor/contrib/suggest/browser/suggestController';
import { SnippetController2 } from 'vs/editor/contrib/snippet/browser/snippetController2'; import { SnippetController2 } from 'vs/editor/contrib/snippet/browser/snippetController2';
import { Schemas } from 'vs/base/common/network';
import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection';
import { ModesHoverController } from 'vs/editor/contrib/hover/browser/hover'; import { ModesHoverController } from 'vs/editor/contrib/hover/browser/hover';
import { ColorDetector } from 'vs/editor/contrib/colorPicker/browser/colorDetector'; import { ColorDetector } from 'vs/editor/contrib/colorPicker/browser/colorDetector';
@ -92,6 +91,7 @@ import { defaultButtonStyles, defaultCountBadgeStyles } from 'vs/platform/theme/
import { GhostTextController } from 'vs/editor/contrib/inlineCompletions/browser/ghostTextController'; import { GhostTextController } from 'vs/editor/contrib/inlineCompletions/browser/ghostTextController';
import { CodeActionController } from 'vs/editor/contrib/codeAction/browser/codeActionController'; import { CodeActionController } from 'vs/editor/contrib/codeAction/browser/codeActionController';
import { IResolvedTextEditorModel, ITextModelContentProvider, ITextModelService } from 'vs/editor/common/services/resolverService'; import { IResolvedTextEditorModel, ITextModelContentProvider, ITextModelService } from 'vs/editor/common/services/resolverService';
import { Schemas } from 'vs/base/common/network';
type TreeElement = ISCMRepository | ISCMInput | ISCMActionButton | ISCMResourceGroup | IResourceNode<ISCMResource, ISCMResourceGroup> | ISCMResource; type TreeElement = ISCMRepository | ISCMInput | ISCMActionButton | ISCMResourceGroup | IResourceNode<ISCMResource, ISCMResourceGroup> | ISCMResource;
@ -1763,18 +1763,7 @@ class SCMInputWidget {
return; return;
} }
let query: string | undefined; const uri = input.repository.provider.inputBoxDocumentUri;
if (input.repository.provider.rootUri) {
query = `rootUri=${encodeURIComponent(input.repository.provider.rootUri.toString())}`;
}
const uri = URI.from({
scheme: Schemas.vscodeSourceControl,
path: `${input.repository.provider.contextValue}/${input.repository.provider.id}/input`,
query
});
if (this.configurationService.getValue('editor.wordBasedSuggestions', { resource: uri }) !== false) { if (this.configurationService.getValue('editor.wordBasedSuggestions', { resource: uri }) !== false) {
this.configurationService.updateValue('editor.wordBasedSuggestions', false, { resource: uri }, ConfigurationTarget.MEMORY); this.configurationService.updateValue('editor.wordBasedSuggestions', false, { resource: uri }, ConfigurationTarget.MEMORY);
} }

View file

@ -60,6 +60,7 @@ export interface ISCMProvider extends IDisposable {
readonly onDidChangeResources: Event<void>; readonly onDidChangeResources: Event<void>;
readonly rootUri?: URI; readonly rootUri?: URI;
readonly inputBoxDocumentUri: URI;
readonly count?: number; readonly count?: number;
readonly commitTemplate: string; readonly commitTemplate: string;
readonly onDidChangeCommitTemplate: Event<string>; readonly onDidChangeCommitTemplate: Event<string>;

View file

@ -62,6 +62,7 @@ export const allApiProposals = Object.freeze({
resolvers: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.resolvers.d.ts', resolvers: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.resolvers.d.ts',
scmActionButton: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.scmActionButton.d.ts', scmActionButton: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.scmActionButton.d.ts',
scmSelectedProvider: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.scmSelectedProvider.d.ts', scmSelectedProvider: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.scmSelectedProvider.d.ts',
scmTextDocument: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.scmTextDocument.d.ts',
scmValidation: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.scmValidation.d.ts', scmValidation: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.scmValidation.d.ts',
semanticSimilarity: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.semanticSimilarity.d.ts', semanticSimilarity: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.semanticSimilarity.d.ts',
showLocal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.showLocal.d.ts', showLocal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.showLocal.d.ts',

View file

@ -0,0 +1,19 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
declare module 'vscode' {
// https://github.com/microsoft/vscode/issues/166615
/**
* Represents the input box in the Source Control viewlet.
*/
export interface SourceControlInputBox {
/**
* The {@link TextDocument text} of the input box.
*/
readonly document: TextDocument;
}
}