development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-02 17:32:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

smoke - allow 30s max for deleting test path (#137725)

Browse source
This commit is contained in:
Benjamin Pasero 2021-12-06 14:08:56 +01:00
parent 4498f73ed7
commit 2085b19a51
No known key found for this signature in database
GPG key ID: C035C296C8A46619
1 changed files with 28 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
test/smoke/src/main.ts
View file

@ -16,6 +16,7 @@ import { ncp } from 'ncp';
import * as vscodetest from 'vscode-test';
import fetch from 'node-fetch';
import { Quality, ApplicationOptions, MultiLogger, Logger, ConsoleLogger, FileLogger } from '../../automation';
import { timeout } from './utils';
import { setup as setupDataLossTests } from './areas/workbench/data-loss.test';
import { setup as setupPreferencesTests } from './areas/preferences/preferences.test';
@ -342,9 +343,34 @@ after(async function () {
}
try {
await new Promise<void>((resolve, reject) => rimraf(testDataPath, { maxBusyTries: 10 }, error => error ? reject(error) : resolve()));
// TODO@tyriar TODO@meganrogge lately deleting the test root
// folder results in timeouts of 60s or EPERM issues which
// seems to indicate that a process (terminal?) holds onto a
// folder within.
//
// Workarounds pushed for mitigation
// - do not end up with mocha timeout errors after 60s by limiting
// this operation to at maximum 30s
// - do not end up with a failing `after` call when deletion failed
//
// Refs: https://github.com/microsoft/vscode/issues/137725
let deleted = false;
await Promise.race([
new Promise<void>((resolve, reject) => rimraf(testDataPath, { maxBusyTries: 10 }, error => {
if (error) {
reject(error);
} else {
deleted = true;
resolve();
}
})),
timeout(30000).then(() => {
if (!deleted) {
throw new Error('giving up after 30s');
}
})
]);
} catch (error) {
// TODO@tyriar TODO@meganrogge https://github.com/microsoft/vscode/issues/137725
console.error(`Unable to delete smoke test workspace: ${error}. This indicates some process is locking the workspace folder.`);
}
});