development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 13:29:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

rename hasExecutionOrder to supportsExecutionOrder

Browse source
This commit is contained in:
Johannes Rieken 2021-05-31 16:09:05 +02:00
parent f2fb2b8cbe
commit 2031df2653
No known key found for this signature in database
GPG key ID: 96634B5AF12F8798
4 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/vs/vscode.d.ts vendored
View file

@ -11938,7 +11938,10 @@ declare module 'vscode' {
* Whether this controller supports execution order so that the
* editor can render placeholders for them.
*/
// todo@API rename to supportsExecutionOrder
supportsExecutionOrder?: boolean;
// todo@API remove
/** @deprecated */
hasExecutionOrder?: boolean;
/**

6
src/vs/workbench/api/browser/mainThreadNotebookKernels.ts
View file

@ -52,7 +52,7 @@ abstract class MainThreadKernel implements INotebookKernel {
this.description = data.description;
this.detail = data.detail;
this.supportedLanguages = isNonEmptyArray(data.supportedLanguages) ? data.supportedLanguages : _modeService.getRegisteredModes();
this.implementsExecutionOrder = data.hasExecutionOrder ?? false;
this.implementsExecutionOrder = data.supportsExecutionOrder ?? false;
this.localResourceRoot = URI.revive(data.extensionLocation);
this.preloads = data.preloads?.map(u => ({ uri: URI.revive(u.uri), provides: u.provides })) ?? [];
}
@ -77,8 +77,8 @@ abstract class MainThreadKernel implements INotebookKernel {
this.supportedLanguages = isNonEmptyArray(data.supportedLanguages) ? data.supportedLanguages : this._modeService.getRegisteredModes();
event.supportedLanguages = true;
}
if (data.hasExecutionOrder !== undefined) {
this.implementsExecutionOrder = data.hasExecutionOrder;
if (data.supportsExecutionOrder !== undefined) {
this.implementsExecutionOrder = data.supportsExecutionOrder;
event.hasExecutionOrder = true;
}
this._onDidChange.fire(event);

2
src/vs/workbench/api/common/extHost.protocol.ts
View file

@ -915,7 +915,7 @@ export interface INotebookKernelDto2 {
description?: string;
supportedLanguages?: string[];
supportsInterrupt?: boolean;
hasExecutionOrder?: boolean;
supportsExecutionOrder?: boolean;
preloads?: { uri: UriComponents; provides: string[] }[];
}

11
src/vs/workbench/api/common/extHostNotebookKernels.ts
View file

@ -143,10 +143,17 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
_update();
},
get hasExecutionOrder() {
return data.hasExecutionOrder ?? false;
return data.supportsExecutionOrder ?? false;
},
set hasExecutionOrder(value) {
data.hasExecutionOrder = value;
data.supportsExecutionOrder = value;
_update();
},
get supportsExecutionOrder() {
return data.supportsExecutionOrder ?? false;
},
set supportsExecutionOrder(value) {
data.supportsExecutionOrder = value;
_update();
},
get rendererScripts() {