development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 13:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Restore notebook layout performance optimization (#172466)" (#175180)

Browse source 
This reverts commit 317f309a26.

Fixes #175179

The root cause is that the grid view is still passing us bad positions. Will open new bug for this
This commit is contained in:
Matt Bierner 2023-02-22 16:40:43 -06:00 committed by GitHub
parent 9cec7256d1
commit 1fa08d1121
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts
View file

@ -1709,7 +1709,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
return this._scrollBeyondLastLine && !this.isEmbedded;
}
layout(dimension: DOM.Dimension, shadowElement?: HTMLElement, position?: DOM.IDomPosition): void {
layout(dimension: DOM.Dimension, shadowElement?: HTMLElement, _position?: DOM.IDomPosition): void {
if (!shadowElement && this._shadowElementViewInfo === null) {
this._dimension = dimension;
return;
@ -1721,7 +1721,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
}
if (shadowElement) {
this.updateShadowElement(shadowElement, dimension, position);
this.updateShadowElement(shadowElement, dimension, /*position*/ undefined);
}
if (this._shadowElementViewInfo && this._shadowElementViewInfo.width <= 0 && this._shadowElementViewInfo.height <= 0) {
@ -1750,7 +1750,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
this._overlayContainer.style.position = 'absolute';
this._overlayContainer.style.overflow = 'hidden';
this.layoutContainerOverShadowElement(dimension, position);
this.layoutContainerOverShadowElement(dimension, /*position*/ undefined);
if (this._webviewTransparentCover) {
this._webviewTransparentCover.style.height = `${dimension.height}px`;