mirror of
https://github.com/Microsoft/vscode
synced 2024-08-27 13:00:58 +00:00
This reverts commit 317f309a26
.
Fixes #175179
The root cause is that the grid view is still passing us bad positions. Will open new bug for this
This commit is contained in:
parent
9cec7256d1
commit
1fa08d1121
|
@ -1709,7 +1709,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
|
|||
return this._scrollBeyondLastLine && !this.isEmbedded;
|
||||
}
|
||||
|
||||
layout(dimension: DOM.Dimension, shadowElement?: HTMLElement, position?: DOM.IDomPosition): void {
|
||||
layout(dimension: DOM.Dimension, shadowElement?: HTMLElement, _position?: DOM.IDomPosition): void {
|
||||
if (!shadowElement && this._shadowElementViewInfo === null) {
|
||||
this._dimension = dimension;
|
||||
return;
|
||||
|
@ -1721,7 +1721,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
|
|||
}
|
||||
|
||||
if (shadowElement) {
|
||||
this.updateShadowElement(shadowElement, dimension, position);
|
||||
this.updateShadowElement(shadowElement, dimension, /*position*/ undefined);
|
||||
}
|
||||
|
||||
if (this._shadowElementViewInfo && this._shadowElementViewInfo.width <= 0 && this._shadowElementViewInfo.height <= 0) {
|
||||
|
@ -1750,7 +1750,7 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditorD
|
|||
this._overlayContainer.style.position = 'absolute';
|
||||
this._overlayContainer.style.overflow = 'hidden';
|
||||
|
||||
this.layoutContainerOverShadowElement(dimension, position);
|
||||
this.layoutContainerOverShadowElement(dimension, /*position*/ undefined);
|
||||
|
||||
if (this._webviewTransparentCover) {
|
||||
this._webviewTransparentCover.style.height = `${dimension.height}px`;
|
||||
|
|
Loading…
Reference in a new issue