development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 05:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename to DocumentOnDropEditProvider (#149730)

Browse source 
This change renames `DocumentOnDropProvider` to `DocumentOnDropEditProvider`. This new name aligns with the existing `DocumentFormattingEditProvider`
This commit is contained in:
Matt Bierner 2022-05-17 09:26:54 -07:00 committed by GitHub
parent 9ae563f53b
commit 1c7ab35761
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 21 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extensions/markdown-language-features/src/languageFeatures/dropIntoEditor.ts
View file

@ -24,7 +24,7 @@ const imageFileExtensions = new Set<string>([
]);
export function registerDropIntoEditor(selector: vscode.DocumentSelector) {
return vscode.languages.registerDocumentOnDropProvider(selector, new class implements vscode.DocumentOnDropProvider {
return vscode.languages.registerDocumentOnDropEditProvider(selector, new class implements vscode.DocumentOnDropEditProvider {
async provideDocumentOnDropEdits(document: vscode.TextDocument, position: vscode.Position, dataTransfer: vscode.DataTransfer, token: vscode.CancellationToken): Promise<vscode.SnippetTextEdit | undefined> {
const enabled = vscode.workspace.getConfiguration('markdown', document).get('editor.drop.enabled', true);
if (!enabled) {

14
src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts
View file

@ -863,19 +863,19 @@ export class MainThreadLanguageFeatures extends Disposable implements MainThread
// --- document drop Edits
private readonly _documentOnDropProviders = new Map<number, MainThreadDocumentOnDropProvider>();
private readonly _documentOnDropEditProviders = new Map<number, MainThreadDocumentOnDropEditProvider>();
$registerDocumentOnDropProvider(handle: number, selector: IDocumentFilterDto[]): void {
const provider = new MainThreadDocumentOnDropProvider(handle, this._proxy);
this._documentOnDropProviders.set(handle, provider);
$registerDocumentOnDropEditProvider(handle: number, selector: IDocumentFilterDto[]): void {
const provider = new MainThreadDocumentOnDropEditProvider(handle, this._proxy);
this._documentOnDropEditProviders.set(handle, provider);
this._registrations.set(handle, combinedDisposable(
this._languageFeaturesService.documentOnDropEditProvider.register(selector, provider),
toDisposable(() => this._documentOnDropProviders.delete(handle)),
toDisposable(() => this._documentOnDropEditProviders.delete(handle)),
));
}
async $resolveDocumentOnDropFileData(handle: number, requestId: number, dataIndex: number): Promise<VSBuffer> {
const provider = this._documentOnDropProviders.get(handle);
const provider = this._documentOnDropEditProviders.get(handle);
if (!provider) {
throw new Error('Could not find provider');
}
@ -883,7 +883,7 @@ export class MainThreadLanguageFeatures extends Disposable implements MainThread
}
}
class MainThreadDocumentOnDropProvider implements languages.DocumentOnDropEditProvider {
class MainThreadDocumentOnDropEditProvider implements languages.DocumentOnDropEditProvider {
private readonly dataTransfers = new DataTransferCache();

4
src/vs/workbench/api/common/extHost.api.impl.ts
View file

@ -570,9 +570,9 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
createLanguageStatusItem(id: string, selector: vscode.DocumentSelector): vscode.LanguageStatusItem {
return extHostLanguages.createLanguageStatusItem(extension, id, selector);
},
registerDocumentOnDropProvider(selector: vscode.DocumentSelector, provider: vscode.DocumentOnDropProvider): vscode.Disposable {
registerDocumentOnDropEditProvider(selector: vscode.DocumentSelector, provider: vscode.DocumentOnDropEditProvider): vscode.Disposable {
checkProposedApiEnabled(extension, 'textEditorDrop');
return extHostLanguageFeatures.registerDocumentOnDropProvider(extension, selector, provider);
return extHostLanguageFeatures.registerDocumentOnDropEditProvider(extension, selector, provider);
}
};

2
src/vs/workbench/api/common/extHost.protocol.ts
View file

@ -392,7 +392,7 @@ export interface MainThreadLanguageFeaturesShape extends IDisposable {
$registerSelectionRangeProvider(handle: number, selector: IDocumentFilterDto[]): void;
$registerCallHierarchyProvider(handle: number, selector: IDocumentFilterDto[]): void;
$registerTypeHierarchyProvider(handle: number, selector: IDocumentFilterDto[]): void;
$registerDocumentOnDropProvider(handle: number, selector: IDocumentFilterDto[]): void;
$registerDocumentOnDropEditProvider(handle: number, selector: IDocumentFilterDto[]): void;
$resolveDocumentOnDropFileData(handle: number, requestId: number, dataIndex: number): Promise<VSBuffer>;
$setLanguageConfiguration(handle: number, languageId: string, configuration: ILanguageConfigurationDto): void;
}

14
src/vs/workbench/api/common/extHostLanguageFeatures.ts
View file

@ -1745,12 +1745,12 @@ class TypeHierarchyAdapter {
}
}
class DocumentOnDropAdapter {
class DocumentOnDropEditAdapter {
constructor(
private readonly _proxy: extHostProtocol.MainThreadLanguageFeaturesShape,
private readonly _documents: ExtHostDocuments,
private readonly _provider: vscode.DocumentOnDropProvider,
private readonly _provider: vscode.DocumentOnDropEditProvider,
private readonly _handle: number,
) { }
@ -1778,7 +1778,7 @@ type Adapter = DocumentSymbolAdapter | CodeLensAdapter | DefinitionAdapter | Hov
| DocumentSemanticTokensAdapter | DocumentRangeSemanticTokensAdapter
| EvaluatableExpressionAdapter | InlineValuesAdapter
| LinkedEditingRangeAdapter | InlayHintsAdapter | InlineCompletionAdapter | InlineCompletionAdapterNew
| DocumentOnDropAdapter;
| DocumentOnDropEditAdapter;
class AdapterData {
constructor(
@ -2402,15 +2402,15 @@ export class ExtHostLanguageFeatures implements extHostProtocol.ExtHostLanguageF
// --- Document on drop
registerDocumentOnDropProvider(extension: IExtensionDescription, selector: vscode.DocumentSelector, provider: vscode.DocumentOnDropProvider) {
registerDocumentOnDropEditProvider(extension: IExtensionDescription, selector: vscode.DocumentSelector, provider: vscode.DocumentOnDropEditProvider) {
const handle = this._nextHandle();
this._adapter.set(handle, new AdapterData(new DocumentOnDropAdapter(this._proxy, this._documents, provider, handle), extension));
this._proxy.$registerDocumentOnDropProvider(handle, this._transformDocumentSelector(selector));
this._adapter.set(handle, new AdapterData(new DocumentOnDropEditAdapter(this._proxy, this._documents, provider, handle), extension));
this._proxy.$registerDocumentOnDropEditProvider(handle, this._transformDocumentSelector(selector));
return this._createDisposable(handle);
}
$provideDocumentOnDropEdits(handle: number, requestId: number, resource: UriComponents, position: IPosition, dataTransferDto: DataTransferDTO, token: CancellationToken): Promise<Dto<languages.SnippetTextEdit> | undefined> {
return this._withAdapter(handle, DocumentOnDropAdapter, adapter =>
return this._withAdapter(handle, DocumentOnDropEditAdapter, adapter =>
Promise.resolve(adapter.provideDocumentOnDropEdits(requestId, URI.revive(resource), position, dataTransferDto, token)), undefined, undefined);
}

6
src/vscode-dts/vscode.proposed.textEditorDrop.d.ts vendored
View file

@ -18,7 +18,7 @@ declare module 'vscode' {
*
* The user can drop into a text editor by holding down `shift` while dragging. Requires `workbench.experimental.editor.dropIntoEditor.enabled` to be on.
*/
export interface DocumentOnDropProvider {
export interface DocumentOnDropEditProvider {
/**
* Provide edits which inserts the content being dragged and dropped into the document.
*
@ -35,13 +35,13 @@ declare module 'vscode' {
export namespace languages {
/**
* Registers a new {@link DocumentOnDropProvider}.
* Registers a new {@link DocumentOnDropEditProvider}.
*
* @param selector A selector that defines the documents this provider applies to.
* @param provider A drop provider.
*
* @return A {@link Disposable} that unregisters this provider when disposed of.
*/
export function registerDocumentOnDropProvider(selector: DocumentSelector, provider: DocumentOnDropProvider): Disposable;
export function registerDocumentOnDropEditProvider(selector: DocumentSelector, provider: DocumentOnDropEditProvider): Disposable;
}
}