development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-09-13 21:55:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Throw when rendering disposed view

Browse source
This commit is contained in:
Henning Dieterichs 2023-11-09 18:55:43 +01:00 committed by Henning Dieterichs
parent f85a095fd2
commit 1a1f560edf
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/vs/editor/browser/view.ts
View file

@ -7,7 +7,7 @@ import * as dom from 'vs/base/browser/dom';
import { Selection } from 'vs/editor/common/core/selection'; import { Selection } from 'vs/editor/common/core/selection';
import { Range } from 'vs/editor/common/core/range'; import { Range } from 'vs/editor/common/core/range';
import { FastDomNode, createFastDomNode } from 'vs/base/browser/fastDomNode'; import { FastDomNode, createFastDomNode } from 'vs/base/browser/fastDomNode';
import { onUnexpectedError } from 'vs/base/common/errors'; import { BugIndicatingError, onUnexpectedError } from 'vs/base/common/errors';
import { IDisposable } from 'vs/base/common/lifecycle'; import { IDisposable } from 'vs/base/common/lifecycle';
import { IPointerHandlerHelper } from 'vs/editor/browser/controller/mouseHandler'; import { IPointerHandlerHelper } from 'vs/editor/browser/controller/mouseHandler';
import { PointerHandler } from 'vs/editor/browser/controller/pointerHandler'; import { PointerHandler } from 'vs/editor/browser/controller/pointerHandler';
@ -431,12 +431,18 @@ export class View extends ViewEventHandler {
} }
private _scheduleRender(): void { private _scheduleRender(): void {
if (this._store.isDisposed) {
throw new BugIndicatingError();
}
if (this._renderAnimationFrame === null) { if (this._renderAnimationFrame === null) {
this._renderAnimationFrame = dom.runAtThisOrScheduleAtNextAnimationFrame(dom.getWindow(this.domNode.domNode), this._onRenderScheduled.bind(this), 100); this._renderAnimationFrame = dom.runAtThisOrScheduleAtNextAnimationFrame(dom.getWindow(this.domNode.domNode), this._onRenderScheduled.bind(this), 100);
} }
} }
private _onRenderScheduled(): void { private _onRenderScheduled(): void {
if (this._store.isDisposed) {
throw new BugIndicatingError();
}
this._renderAnimationFrame = null; this._renderAnimationFrame = null;
this._flushAccumulatedAndRenderNow(); this._flushAccumulatedAndRenderNow();
} }
@ -457,6 +463,10 @@ export class View extends ViewEventHandler {
} }
private _actualRender(): void { private _actualRender(): void {
if (this._store.isDisposed) {
throw new BugIndicatingError();
}
if (!this.domNode.domNode.isConnected) { if (!this.domNode.domNode.isConnected) {
return; return;
} }