development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 21:09:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Show JSON schema resolution errors in status bar only

Browse source 
This commit adds a middleware to the JSON Language Feature client
which intercepts diagnostics for schema resolution errors, and shows
them in the status bar instead of treating them as code errors.

Fixes #51032
This commit is contained in:
Literallie 2018-10-09 01:41:08 +02:00
parent 09afa054ee
commit 157ee8c394
No known key found for this signature in database
GPG key ID: 7BE463C902ED152C
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
extensions/json-language-features/client/src/jsonMain.ts
View file

@ -8,8 +8,8 @@ import * as fs from 'fs';
import * as nls from 'vscode-nls';
const localize = nls.loadMessageBundle();
import { workspace, languages, ExtensionContext, extensions, Uri, LanguageConfiguration } from 'vscode';
import { LanguageClient, LanguageClientOptions, RequestType, ServerOptions, TransportKind, NotificationType, DidChangeConfigurationNotification } from 'vscode-languageclient';
import { workspace, window, languages, ExtensionContext, extensions, Uri, LanguageConfiguration, Diagnostic } from 'vscode';
import { LanguageClient, LanguageClientOptions, RequestType, ServerOptions, TransportKind, NotificationType, DidChangeConfigurationNotification, HandleDiagnosticsSignature } from 'vscode-languageclient';
import TelemetryReporter from 'vscode-extension-telemetry';
import { hash } from './utils/hash';
@ -89,6 +89,16 @@ export function activate(context: ExtensionContext) {
middleware: {
workspace: {
didChangeConfiguration: () => client.sendNotification(DidChangeConfigurationNotification.type, { settings: getSettings() })
},
handleDiagnostics: (uri: Uri, diagnostics: Diagnostic[], next: HandleDiagnosticsSignature) => {
let schemaResolveDiagnostic = diagnostics
.find(candidate => candidate.code === /* SchemaResolveError */ 0x300);
if (schemaResolveDiagnostic) {
// Show schema resolution errors in status bar only; ref: #51032
window.showWarningMessage(schemaResolveDiagnostic.message);
} else {
next(uri, diagnostics);
}
}
}
};