development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-10-05 19:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change how placeholders in parsed markdown links are created (#201851)

Browse source 
Fixes #186284

See https://github.com/microsoft/vscode/issues/186284#issuecomment-1877968127 for details

Also fixes the tab order to always start from the top most range in the document
This commit is contained in:
Matt Bierner 2024-01-04 17:21:09 -08:00 committed by GitHub
parent 6079e24015
commit 14b09484ff
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
extensions/markdown-language-features/src/languageFeatures/copyFiles/shared.ts
View file

@ -93,16 +93,22 @@ export function createInsertUriListEdit(
}
const edits: vscode.SnippetTextEdit[] = [];
let placeHolderValue = ranges.length;
let insertedLinkCount = 0;
let insertedImageCount = 0;
let insertedAudioVideoCount = 0;
for (const range of ranges) {
// Use 1 for all empty ranges but give non-empty range unique indices starting after 1
let placeHolderStartIndex = 1 + entries.length;
// Sort ranges by start position
const orderedRanges = [...ranges].sort((a, b) => a.start.compareTo(b.start));
const allRangesAreEmpty = orderedRanges.every(range => range.isEmpty);
for (const range of orderedRanges) {
const snippet = createUriListSnippet(document.uri, entries, {
placeholderText: !range.isEmpty ? document.getText(range) : undefined,
placeholderStartIndex: placeHolderValue,
placeholderText: range.isEmpty ? undefined : document.getText(range),
placeholderStartIndex: allRangesAreEmpty ? 1 : placeHolderStartIndex,
});
if (!snippet) {
continue;
@ -112,7 +118,8 @@ export function createInsertUriListEdit(
insertedImageCount += snippet.insertedImageCount;
insertedAudioVideoCount += snippet.insertedAudioVideoCount;
placeHolderValue--;
placeHolderStartIndex += entries.length;
edits.push(new vscode.SnippetTextEdit(range, snippet.snippet));
}