development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-27 04:49:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix slow command palette (#171090)

Browse source
This commit is contained in:
SteVen Batten 2023-01-11 11:29:24 -08:00 committed by GitHub
parent 89e427274e
commit 12515569ae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/vs/platform/actions/common/menuService.ts
View file

@ -48,6 +48,8 @@ class PersistedMenuHideState {
private _ignoreChangeEvent: boolean = false;
private _data: Record<string, string[] | undefined>;
private _hiddenByDefaultCache = new Map<string, boolean>();
constructor(@IStorageService private readonly _storageService: IStorageService) {
try {
const raw = _storageService.get(PersistedMenuHideState._key, StorageScope.PROFILE, '{}');
@ -78,14 +80,11 @@ class PersistedMenuHideState {
}
private _isHiddenByDefault(menu: MenuId, commandId: string) {
let hiddenByDefault = false;
for (const item of MenuRegistry.getMenuItems(menu)) {
if (isIMenuItem(item) && item.command.id === commandId) {
hiddenByDefault = Boolean(item.isHiddenByDefault);
break;
}
}
return hiddenByDefault;
return this._hiddenByDefaultCache.get(`${menu.id}/${commandId}`) ?? false;
}
setDefaultState(menu: MenuId, commandId: string, hidden: boolean): void {
this._hiddenByDefaultCache.set(`${menu.id}/${commandId}`, hidden);
}
isHidden(menu: MenuId, commandId: string): boolean {
@ -239,6 +238,10 @@ class MenuInfo {
for (const item of items) {
if (this._contextKeyService.contextMatchesRules(item.when)) {
const isMenuItem = isIMenuItem(item);
if (isMenuItem) {
this._hiddenStates.setDefaultState(this._id, item.command.id, !!item.isHiddenByDefault);
}
const menuHide = createMenuHide(this._id, isMenuItem ? item.command : item, this._hiddenStates);
if (isMenuItem) {
// MenuItemAction