From 0fa6b06a1df92438854daf91f64bc2e1c5e248ee Mon Sep 17 00:00:00 2001 From: Connor Peet Date: Wed, 9 Feb 2022 11:04:07 -0800 Subject: [PATCH] testing: fix non-error outputs not being clickable Fixes #142602 --- src/vs/workbench/contrib/testing/browser/media/testing.css | 3 +++ .../workbench/contrib/testing/browser/testingDecorations.ts | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/contrib/testing/browser/media/testing.css b/src/vs/workbench/contrib/testing/browser/media/testing.css index c92c480870f..0adef01ac92 100644 --- a/src/vs/workbench/contrib/testing/browser/media/testing.css +++ b/src/vs/workbench/contrib/testing/browser/media/testing.css @@ -209,5 +209,8 @@ .test-message-inline-content { font-family: var(--testMessageDecorationFontFamily); font-size: var(--testMessageDecorationFontSize); +} + +.test-message-inline-content-clickable { cursor: pointer; } diff --git a/src/vs/workbench/contrib/testing/browser/testingDecorations.ts b/src/vs/workbench/contrib/testing/browser/testingDecorations.ts index 5b887c4a96c..928bd786a5e 100644 --- a/src/vs/workbench/contrib/testing/browser/testingDecorations.ts +++ b/src/vs/workbench/contrib/testing/browser/testingDecorations.ts @@ -267,7 +267,7 @@ export class TestingDecorationService extends Disposable implements ITestingDeco continue; } - const messageUri = m.type === TestMessageType.Info ? undefined : buildTestUri({ + const messageUri = buildTestUri({ type: TestUriType.ResultActualOutput, messageIndex: i, taskIndex: taskId, @@ -894,7 +894,7 @@ class TestMessageDecoration implements ITestDecoration { options.after = { content: ' '.repeat(4) + inlineText, - inlineClassName: `test-message-inline-content test-message-inline-content-s${severity} ${this.contentIdClass}` + inlineClassName: `test-message-inline-content test-message-inline-content-s${severity} ${this.contentIdClass} ${messageUri ? 'test-message-inline-content-clickable' : ''}` }; options.showIfCollapsed = true;