development/vscode
development/vscode
1
0
Fork 0
mirror of https://github.com/Microsoft/vscode synced 2024-08-28 05:19:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

SCM - fix listener leak (#214037)

Browse source
This commit is contained in:
Ladislau Szomoru 2024-05-31 21:20:40 +02:00 committed by GitHub
parent 26ac001e1c
commit 0f4cbebe13
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/vs/workbench/contrib/scm/common/scmService.ts
View file

@ -3,7 +3,7 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import { DisposableStore, IDisposable, toDisposable } from 'vs/base/common/lifecycle';
import { Disposable, DisposableStore, IDisposable, toDisposable } from 'vs/base/common/lifecycle';
import { Event, Emitter } from 'vs/base/common/event';
import { ISCMService, ISCMProvider, ISCMInput, ISCMRepository, IInputValidator, ISCMInputChangeEvent, SCMInputChangeReason, InputValidationType, IInputValidation } from './scm';
import { ILogService } from 'vs/platform/log/common/log';
@ -16,7 +16,7 @@ import { URI } from 'vs/base/common/uri';
import { Iterable } from 'vs/base/common/iterator';
import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
class SCMInput implements ISCMInput {
class SCMInput extends Disposable implements ISCMInput {
private _value = '';
@ -104,9 +104,11 @@ class SCMInput implements ISCMInput {
readonly repository: ISCMRepository,
private readonly history: SCMInputHistory
) {
super();
if (this.repository.provider.rootUri) {
this.historyNavigator = history.getHistory(this.repository.provider.label, this.repository.provider.rootUri);
this.history.onWillSaveHistory(event => {
this._register(this.history.onWillSaveHistory(event => {
if (this.historyNavigator.isAtEnd()) {
this.saveValue();
}
@ -116,7 +118,7 @@ class SCMInput implements ISCMInput {
}
this.didChangeHistory = false;
});
}));
} else { // in memory only
this.historyNavigator = new HistoryNavigator2([''], 100);
}